From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: master 160b4c295d8: ; * src/process.c (child_signal_notify): Avoid compiler warning (bug#65919).
Date: Mon, 18 Sep 2023 15:51:20 +0200 [thread overview]
Message-ID: <875y47k2sn.fsf@gmail.com> (raw)
In-Reply-To: <20230915060543.76EF0C051F1@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 15 Sep 2023 02:05:43 -0400 (EDT)")
>>>>> On Fri, 15 Sep 2023 02:05:43 -0400 (EDT), Eli Zaretskii <eliz@gnu.org> said:
Eli> branch: master
Eli> commit 160b4c295d8975755d4a8cc4ba6b6b75a549ed3c
Eli> Author: Eli Zaretskii <eliz@gnu.org>
Eli> Commit: Eli Zaretskii <eliz@gnu.org>
Eli> ; * src/process.c (child_signal_notify): Avoid compiler warning (bug#65919).
Eli> ---
Eli> src/process.c | 18 ++++++++++++------
Eli> 1 file changed, 12 insertions(+), 6 deletions(-)
Eli> diff --git a/src/process.c b/src/process.c
Eli> index 7410256dae9..2376d0f288d 100644
Eli> --- a/src/process.c
Eli> +++ b/src/process.c
Eli> @@ -7415,10 +7415,14 @@ child_signal_notify (void)
Eli> int fd = child_signal_write_fd;
Eli> eassert (0 <= fd);
Eli> char dummy = 0;
Eli> - if (emacs_write (fd, &dummy, 1) != 1)
Eli> - /* This call is commented out. It calls `emacs_perror', which in
Eli> - turn invokes a localized version of strerror that is not
Eli> - reentrant and must not be called within a signal
Eli> handler:
Is it worth the effort to use strerror_r-posix here from Gnulib? Weʼd
have to use a static char buffer to avoid malloc, but it might be
better than nothing.
Robert
--
next parent reply other threads:[~2023-09-18 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169475794317.12794.4825888702595787215@vcs2.savannah.gnu.org>
[not found] ` <20230915060543.76EF0C051F1@vcs2.savannah.gnu.org>
2023-09-18 13:51 ` Robert Pluim [this message]
2023-09-18 19:35 ` bug#65919: master 160b4c295d8: ; * src/process.c (child_signal_notify): Avoid compiler warning (bug#65919) Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y47k2sn.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.