From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manphiz Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Thu, 21 Sep 2023 09:57:57 -0700 Message-ID: <875y4331m2.fsf@debian-hx90.lan> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19243"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65882-done@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 18:59:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjN1C-0004ky-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 18:59:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjN0x-0005WW-9z; Thu, 21 Sep 2023 12:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjN0v-0005TO-8n for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:58:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjN0v-0000JD-0T for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:58:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjN14-0002b6-B1 for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manphiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.16953155019930 (code D ref 65882); Thu, 21 Sep 2023 16:59:02 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 21 Sep 2023 16:58:21 +0000 Original-Received: from localhost ([127.0.0.1]:34732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjN0O-0002a6-Ls for submit@debbugs.gnu.org; Thu, 21 Sep 2023 12:58:21 -0400 Original-Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:59801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjN0J-0002Zp-Hk for 65882-done@debbugs.gnu.org; Thu, 21 Sep 2023 12:58:19 -0400 Original-Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1c43166b7e5so10096965ad.3 for <65882-done@debbugs.gnu.org>; Thu, 21 Sep 2023 09:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695315479; x=1695920279; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VndhgGNjZTa/GZrvD5+7VKOSCGlCYCJA9w0iSfYxCeU=; b=kMzQTdnGPaLJVTI4iEQuM+rEHTf682YvqeM18iehzqGbUJYXI9HCYXv7qAB3yG/syJ GM1ikmavAN02+1bYrzbRORzJXwgYwn070UVC1lxGmsiZej3i7ycyJWEgVfU7ukXi4LmY EHk4oQhLVuSvVMLIJGoIEkJ2VEiV8mQo7p25r2HDjndknJAWbfs5ocyXTNzaTHp+tezy HTAwA+MEBiez9ztX023XmGzVaarPFHL2Bah56u5PWnajxqgbCN9rVLWCU/hth0ltTWUR YpDWZZ1TlJg2BzJjPXPAOB3gywfnBqS3I9Dv42B8YVR/+fPbz2q2SGHFYFQVlTkl1pZZ M3sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695315479; x=1695920279; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VndhgGNjZTa/GZrvD5+7VKOSCGlCYCJA9w0iSfYxCeU=; b=jwgHwaQeeuHq3K4lqcow7lDPaxYhALj0PVcwD91A6KomGcwmuemDQazXBXfCt4ee3Z 4IyB4ot8cqNPuedRbLh1zfLgkg0rbMoQzJQRRyHXODxqb1MGhr3QEnyFjNSaH89bE268 oEKDqChoIskmZNQcRMADGhNZtKfPKqyvvX+5mewBLsA98TUxjUPmYN9ENG0iGjq5cuGu urMFRFJMh3AnNBVctgNMGxfgCI5uNg7bdMYRKmUwr8EGPyrOjF8Yuv2iJ3RHNobudwFk SbNff2EE66j7gdHPZoQH8mIQ7LtIdHf61tt79yWxE37XFRfM6U2RjhlJA0xK9SWooiAR GL4g== X-Gm-Message-State: AOJu0Yx5QO7oImR3MKtkM3juLyf1fmdgYuAgEAlDPHOWTHvMfFEo1km7 FqzAZvOd+DpDzAfvRX+Izac= X-Google-Smtp-Source: AGHT+IETkYdIo94X2vh7Lok5GAH/rQm2x9liiuU/4EMN04vvC1PfJCMH5AC4ZTO5MHLH5a36/huWEw== X-Received: by 2002:a17:90b:88e:b0:262:d6cb:3567 with SMTP id bj14-20020a17090b088e00b00262d6cb3567mr6225889pjb.26.1695315479214; Thu, 21 Sep 2023 09:57:59 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-4543-1b99-0367-6d9f.res6.spectrum.com. [2603:8000:a400:cdc:4543:1b99:367:6d9f]) by smtp.gmail.com with ESMTPSA id 11-20020a17090a19cb00b002747fbd9bbfsm3589433pjj.37.2023.09.21.09.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 09:57:58 -0700 (PDT) In-Reply-To: <87r0mrwkyp.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 21 Sep 2023 16:27:10 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271007 Archived-At: Philip Kaludercic writes: > Manphiz writes: > >> Philip Kaludercic writes: >> >>> The change makes sense, but I'll want to try it out to make sure we are >>> doing the right thing. Unless I write something here, ping me in a few >>> days. These kinds of auto-reconnect bugs can be annoying to debug in >>> real-life situations. >>> >> >> Friendly ping. > > I haven't noticed any issues, and the change makes sense. I'll apply it > to master. Thanks! > Great, thanks! Additionally, is it OK to backport this to 29 branch or even 28 branch? Or is there any automatic backport process for release branches? >>> Manphiz writes: >>> >>>> Stefan Kangas writes: >>>> >>>>> severity 65882 + minor >>>>> thanks >>>>> >>>>> Manphiz writes: >>>>> >>>>>> I noticed that you lowered the severity of this bug from "normal" to >>>>>> "wishlist". AIUI rcirc provides a way to automatically join channels >>>>>> upon connecting to a server and currently this is not working as >>>>>> intended, so IMHO it should be considered a bug instead of a feature >>>>>> request (a wishlist). >>>>> >>>>> Thanks, so I bumped it to minor. I hope that makes more sense. >>>>> >>>> >>>> Thanks! >>>> >>>>>> (If you are using severity as a means to manage bug triage priority >>>>>> I'm OK with that.) >>>>> >>>>> My impression is that almost no one pays attention to bug severities, so >>>>> I wouldn't make too much of it. Bug reports that come with a patch, >>>>> like yours did, tend to get more visibility though. >>>>> >>>> >>>> Ah got it. It's my first time filing bug here so not very familiar with >>>> the convention. Looks like tagging patch was a good move :) >>> >>> So this patch would be applied without a copyright assignment, right? >>> >>>>>> Personally, as the patch is sufficiently trivial, I would hope it won't >>>>>> take too much work for a review. But I would understand if dealing with >>>>>> rcirc-user-authenticated is more involved than it looks like and should >>>>>> be handled with care. >>>>> >>>>> I've copied in the rcirc maintainers. Let's see if they have any >>>>> comments first. >>>> >>>> Great! Thanks again! -- Manphiz