all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 66551@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#66551: [PATCH] Add completion for Unix 'doas' command.
Date: Sun, 15 Oct 2023 16:36:52 +0000	[thread overview]
Message-ID: <875y377sgr.fsf@mailbox.org> (raw)
In-Reply-To: <87y1g454y3.fsf@gmail.com> (Visuwesh's message of "Sun, 15 Oct 2023 20:05:32 +0530")

Visuwesh <visuweshm@gmail.com> writes:

> Could we not provide completion for -u and -C?  I have the following
> function in my init.el:
>
>     (defun pcomplete/doas ()
>       "Completion for the `doas' command."
>       (when (string-prefix-p "-" (pcomplete-arg 0))
>         (pcomplete-opt "Lnsu(pcmpl-unix-user-names)C(pcomplete-entries nil #'file-regular-p)"))
>       (funcall pcomplete-command-completion-function)
>       (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
>                pcomplete-default-completion-function)))
>

Thanks, that is better. However the -C file completion doesn't work for
me unless I reorder the pcomplete-opt flags like this:

;;;###autoload
(defun pcomplete/doas ()
  "Completion for the `doas' command."
  (pcomplete-opt
   "C(pcomplete-entries nil #'file-regular-p)Lnsu(pcmpl-unix-user-names)")
  (funcall pcomplete-command-completion-function)
  (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
               pcomplete-default-completion-function)))

The above also lets pcomplete-opt handle the '-' prefix. WDYT?





  reply	other threads:[~2023-10-15 16:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15  0:39 bug#66551: [PATCH] Add completion for Unix 'doas' command Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15  7:58 ` Stefan Kangas
2023-10-15 11:29   ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 12:55     ` Stefan Kangas
2023-10-15 13:41       ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 14:09         ` Stefan Kangas
2023-10-15 14:35         ` Visuwesh
2023-10-15 16:36           ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-21 10:08             ` Stefan Kangas
2023-10-21 18:47               ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 22:44                 ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y377sgr.fsf@mailbox.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66551@debbugs.gnu.org \
    --cc=antero@mailbox.org \
    --cc=stefankangas@gmail.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.