From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Thierry Volpiatto <thievol@posteo.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Thu, 19 Oct 2023 06:16:13 +0000
Message-ID: <875y3386ep.fsf@posteo.net>
References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="26306"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 66394@debbugs.gnu.org
To: Michael Heerdegen <michael_heerdegen@web.de>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 19 08:37:59 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1qtMfP-0006dz-Dq
	for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Oct 2023 08:37:59 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1qtMf5-0005l7-OL; Thu, 19 Oct 2023 02:37:39 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qtMf2-0005kN-4W
 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 02:37:36 -0400
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qtMf1-0003Nt-DR
 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 02:37:35 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qtMfR-0002W1-Ps
 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 02:38:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Thierry Volpiatto <thievol@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Thu, 19 Oct 2023 06:38:01 +0000
Resent-Message-ID: <handler.66394.B66394.16976974679648@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66394
X-GNU-PR-Package: emacs
Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.16976974679648
 (code B ref 66394); Thu, 19 Oct 2023 06:38:01 +0000
Original-Received: (at 66394) by debbugs.gnu.org; 19 Oct 2023 06:37:47 +0000
Original-Received: from localhost ([127.0.0.1]:35691 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1qtMfD-0002VY-C6
 for submit@debbugs.gnu.org; Thu, 19 Oct 2023 02:37:47 -0400
Original-Received: from mout01.posteo.de ([185.67.36.65]:36317)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <thievol@posteo.net>) id 1qtMf9-0002VG-Vg
 for 66394@debbugs.gnu.org; Thu, 19 Oct 2023 02:37:46 -0400
Original-Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 2FBD7240028
 for <66394@debbugs.gnu.org>; Thu, 19 Oct 2023 08:37:11 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1697697431; bh=8JEmQvjW8LQWL1eCoTixuRYLMTb+ILx1kaCOJcMtchg=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From;
 b=czxEEk/Qez9SYH0RwkF9ElHnmSCXGJ79eMq8IfK/tZGg18G5cVT28q4ubinrprpS7
 8JvUyzrwIrI3jZbG8+Qla72vx62/h3cWRawK25mwQNodfhUHS3aAgWy+mUt0Q3Dqi+
 C3LSPJCQb8C/CAzUvYNEL3INIA98Rv3lIgcmrHhu8PH94pV00+fHOZ8R/srTxa4ig2
 EqHDWW34T0+qp1c5tfouxrBDsJGXtaWEJn3T+vH+aif49qvJRTR1vjMeFpRvmU6vIr
 D8H656Ob08tUhI9kXEFpjjgYizBxJZ5tglBRVvw1XJ17FHOtmmzwp7ugfv6jC0UChl
 FNYf1Wuwpj0/A==
Original-Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4S9ygV0JmPz6tn4;
 Thu, 19 Oct 2023 08:37:09 +0200 (CEST)
In-reply-to: <87sf67qqmp.fsf@web.de>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:272702
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/272702>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hello Michael,

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> When using `copy-to-register`, it is hard to see which register is
>> already taken in the preview buffer.  This patch highlight the
>> register entered at prompt if it is already taken otherwise a
>> minibuffer message is sent to notify user the register is available.
>> If any interest here is the patch, feel free to modify if needed.
>
> I am not sure what's the best way to address this kind of problem.  If
> your version is accepted, I would vote for an option to get the old
> behavior back.  Your intended behavior is safer but requires more keys
> (at least confirmation with RET).  Some people might prefer the old way.

There is only RET as additional key and it is a good thing IMO as it let
the time to user to see what he is doing.  Anyway using a real
minibuffer with its keymap is much better and allows further
modifications in the future to fit the needs of everybody. Using
read-key doesn't allow more alternatives.

> I'm also not sure about the visual feedback.  If you use lots of
> registers you might miss your register highlighting in the preview
> buffer.

It's easy to make the selection always visible, now fixed, thanks.

> Maybe using the minibuffer always for the visual feedback might be
> better, I don't know.  Or give only feedback when the register is
> already taken?  Or maybe require the user to hit RET two times to
> confirm overwriting?

Don't think it is necessary with the register highlighting, and with the
real minibuffer, we must hit RET at least one time to exit wich act as a
confirmation (previously read-key was exiting immediately).
>
> Personally I hacked the code so that I can lock registers I don't want
> to overwrite.  I can also restore registers.  That takes away a bit of
> the pressure.

Ok, that's another approach but doesn't help to see what is available or
not.
Note that now you can use M-n to select in minibuffer the available keys (t=
his
only for setting or modifying a register).

> There also had been a request to be able to delete register bindings,
> but it had been rejected.

You can delete your registers with helm, but this is unrelated to this
thread.

> In any way there should be some way to allow a cleaner working with
> registers.

Probably what I propose is not perfect but it is a first step to have
something better than what we have actually.

Thanks for your feedback.

> Just my two cents.
>
>
> Michael.


=2D-=20
Thierry

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmUwzo4THHRoaWV2b2xA
cG9zdGVvLm5ldAAKCRAOxW0UHRbvk/gQDACgC9gKdSMvTTV7zTiNDILllS5Pi0XT
myJqwdca9QK3LbM/x2gRVQH62aIQkRFR490uM1uJXWIR3EFt9pu2nAvq5fT2q/BZ
XW4Z2V8RHG2HZJAj/rWE0Qxuv5MqZPbTsfx9f5PvhPs09Rm01ShXGIxgC+PPEAFt
wBur2qFgH9rS0QZ6dowPWZe40HHyR2D8XzqcDo/OyL7NZ5XulQL06MgaozcNl8/X
0yxXxwRRNKc83lZ5iSVBPrE33CH0p+sOeT57WUzwkzlH848PsZ+w340QDadxOcKc
wssfxc29MM6LcOCtpzFsYvlr3QnLGWx/1AmNFt+Pn9GtSwEp8oYeS8DrOQXZJ8TG
75Y9fQAbSU3dCugYipoy6p+wrNfw/CYTBBOYRDkNGEbn9cRxWyfpf8kIHjc/Y3Mj
4zm6w7Yqn0reifgQhiTRWjIFl4fIaU3kG7C4U83tB9+IhpR7g82i6+YROTnSNWgD
moOpKzp4DeT4hgr1so9v28OSY+5RH0Q0w40=
=hupe
-----END PGP SIGNATURE-----
--=-=-=--