From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Tue, 09 Jan 2024 15:47:45 +0000 Message-ID: <875y02y0da.fsf@localhost> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40333"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, Eli Zaretskii , emacs-orgmode@gnu.org, Max Nikulin , iota@whxvd.name To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 16:45:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNEIT-000ALo-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 16:45:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNEHk-0005DV-3I; Tue, 09 Jan 2024 10:45:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEHg-0005D6-6h for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 10:44:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNEHf-0002ye-4j for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 10:44:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNEHl-00009E-Ip for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 10:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.1704815091537 (code B ref 65734); Tue, 09 Jan 2024 15:45:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 9 Jan 2024 15:44:51 +0000 Original-Received: from localhost ([127.0.0.1]:40695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEHa-00008Z-R6 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 10:44:51 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:60329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEHY-00008I-0j for 65734@debbugs.gnu.org; Tue, 09 Jan 2024 10:44:49 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2915B24002A for <65734@debbugs.gnu.org>; Tue, 9 Jan 2024 16:44:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704815075; bh=6O9IISuM70hvzxrbjoS28SRPmKT/l2AiMgrzosast6k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=WwSfNu35f2izpyqlOQsMVXosHBvpNwyIKNY/Zp41Cb8ygZQ19TdJ+tm4AtuhQF01R bUVY2S0RvJ6YfUc5fsa7m3UguRup7YYV/s34Sykf5Kaj+apn89ARptJ5mvu5+/Yg1j af5D+/JI8wXTErWfQnoi1VhKzY7jl3huWoseyLOOTepNL4jvHvyiwKxtucMn94rorx SOLZCJdGcNG7ilyLywmiEv2gbWfFIFRF45KzFUkPSD5d5pqnzd2faTZ1bhv6YaXeOk VPHBdATRXzNdYNlpIy71VmB6FYLa57i2P6l8bUu+ov/wax8MCofsxbfl+MUl55FGW0 UvW73S2o69lbg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T8ZxF5zhtz6tm4; Tue, 9 Jan 2024 16:44:33 +0100 (CET) In-Reply-To: <875y04yq9s.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277633 gmane.emacs.orgmode:158938 Archived-At: Ihor Radchenko writes: > Stefan Monnier writes: > >> But in addition to that, I suspect that Org should probably not modify >> visibility directly from the modification hooks. Instead, its >> modification hook function should just stash the info somewhere and then >> update the visibility later on, such as in a `post-command-hook`, timer, >> `pre-redisplay-functions`, younameit. > > Good idea. At least, for this specific feature in Org mode. Now, done. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9702a09e Although, I am still interested to pursue feature request to allow customizing `kill-whole-line' and `kill-line' by major modes. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id ABV2CzxqnWWAXQAAkFu2QA (envelope-from ) for ; Tue, 09 Jan 2024 16:46:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id mFPDBTxqnWXENAEAe85BDQ (envelope-from ) for ; Tue, 09 Jan 2024 16:46:04 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WwSfNu35; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704815163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bQeCPPPMqneV0pWuiVu3wMu9lHKsTQyU5a1tgJb6cjc=; b=S76xYTJdl9aW04qoY2o4O9yt1JXp44eu24aZ1zwD75qZ+NAmGUIvn6U/u7OOZVEZXf+182 /UkNXFJRdLq3lC59DCs5DPsK/fUrfqUqpxIalxtd6batwndjnUZ7/psyqZOp1fQE35V4i0 n0jy1QSs2WxjGsPPGtDvLyc/1XGo0a8P/b/WdD46XadtUz0ePBd096x4Jrp2a36aVXStkR 3N5ehtWwzucuf8qDyGILJDlUD19g9Gad4ZecgLnnYraNGr9Zfs9Hwwtmsg1gz2buFpPbcK vZxLU9jbgReueTLAiaP55Qimpub7RYbt3XofVW9dwVdnt+c8E7XCC4Vl6CfBhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WwSfNu35; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704815163; a=rsa-sha256; cv=none; b=GzGDR98vWW6T9b+C7gKruv6xKXU5MkZdPpnB0UrkdoFgRJr/6MkJjvZu67EtBDDQEGKqTM jxzro7/tnVTjVqmFMKi/2/nMRC6DfoGacH9D/jdLMVQ5ddc2CCtooSIDVM9kPghIvxJany GpQlY1GCgGoP8QSpoPwVDjKsHnvKIrHrAXVIVijvDITrdeoo98tyvJW8qqJz2cE/1yBvlP 8xSgFnu1JSYwtfjByQSg2jShmjYtCR9q5nyGYrSDUtBRRxEr9tT/JtMixkWqBC7M4/EYa9 nORkbbt5pIB33PlkzSVQBKdF4Wp8nrNbSVJlZ5fnkBDmml/3+cdvSn1FMLb1xQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9FCD150F4 for ; Tue, 9 Jan 2024 16:46:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNEHk-0005DZ-0B; Tue, 09 Jan 2024 10:45:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEHg-0005DF-VN for emacs-orgmode@gnu.org; Tue, 09 Jan 2024 10:44:56 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEHe-0002vG-RR for emacs-orgmode@gnu.org; Tue, 09 Jan 2024 10:44:56 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 255E4240104 for ; Tue, 9 Jan 2024 16:44:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704815075; bh=6O9IISuM70hvzxrbjoS28SRPmKT/l2AiMgrzosast6k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=WwSfNu35f2izpyqlOQsMVXosHBvpNwyIKNY/Zp41Cb8ygZQ19TdJ+tm4AtuhQF01R bUVY2S0RvJ6YfUc5fsa7m3UguRup7YYV/s34Sykf5Kaj+apn89ARptJ5mvu5+/Yg1j af5D+/JI8wXTErWfQnoi1VhKzY7jl3huWoseyLOOTepNL4jvHvyiwKxtucMn94rorx SOLZCJdGcNG7ilyLywmiEv2gbWfFIFRF45KzFUkPSD5d5pqnzd2faTZ1bhv6YaXeOk VPHBdATRXzNdYNlpIy71VmB6FYLa57i2P6l8bUu+ov/wax8MCofsxbfl+MUl55FGW0 UvW73S2o69lbg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T8ZxF5zhtz6tm4; Tue, 9 Jan 2024 16:44:33 +0100 (CET) From: Ihor Radchenko To: Stefan Monnier Cc: emacs-orgmode@gnu.org, Eli Zaretskii , 65734@debbugs.gnu.org, Max Nikulin , iota@whxvd.name Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <875y04yq9s.fsf@localhost> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> Date: Tue, 09 Jan 2024 15:47:45 +0000 Message-ID: <875y02y0da.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.92 X-Spam-Score: -4.92 X-Migadu-Queue-Id: B9FCD150F4 X-TUID: vG28UZBGBiUn Ihor Radchenko writes: > Stefan Monnier writes: > >> But in addition to that, I suspect that Org should probably not modify >> visibility directly from the modification hooks. Instead, its >> modification hook function should just stash the info somewhere and then >> update the visibility later on, such as in a `post-command-hook`, timer, >> `pre-redisplay-functions`, younameit. > > Good idea. At least, for this specific feature in Org mode. Now, done. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9702a09e Although, I am still interested to pursue feature request to allow customizing `kill-whole-line' and `kill-line' by major modes. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at