From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66554: [PATCH] Add the public API of Compat to the core Date: Thu, 11 Jan 2024 20:24:25 +0000 Message-ID: <875xzzpqiu.fsf@posteo.net> References: <87pm1ggrdx.fsf@posteo.net> <87bk9scucg.fsf@daniel-mendler.de> <87y1cwpanh.fsf@posteo.net> <877ckgpa45.fsf@daniel-mendler.de> <87mstbpyd7.fsf@posteo.net> <87h6jjah1g.fsf@daniel-mendler.de> <87edenptba.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37781"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , eliz@gnu.org, Stefan Kangas , 66554@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 21:25:52 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rO1cb-0009Ui-3q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 21:25:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO1c2-0007r7-FS; Thu, 11 Jan 2024 15:25:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO1bt-0007qk-I1 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 15:25:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rO1bs-0006CX-Oa for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 15:25:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rO1bq-00087w-91 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 15:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66554-submit@debbugs.gnu.org id=B66554.170500467331192 (code B ref 66554); Thu, 11 Jan 2024 20:25:02 +0000 Original-Received: (at 66554) by debbugs.gnu.org; 11 Jan 2024 20:24:33 +0000 Original-Received: from localhost ([127.0.0.1]:34019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1bM-000871-RS for submit@debbugs.gnu.org; Thu, 11 Jan 2024 15:24:33 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:34695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1bK-00086m-Th for 66554@debbugs.gnu.org; Thu, 11 Jan 2024 15:24:31 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1A9BE240027 for <66554@debbugs.gnu.org>; Thu, 11 Jan 2024 21:24:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705004667; bh=FDYb8Lx38QUEPX1k8rqpY9EsvCTi6xso5oC3MfM8AZ0=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=or7GE6KXhp4tX7r2Zme5e8kOpGX2iP+0/D7fcHFNeUMiSFmREGlLxs0ZzTLqlrMcT cbspFlxSV/XcvXlLPHDufKivhZ4bgRYJDCQ34KOz5fwZawTD1F4aw1s+kNPwm1uM8C MKSVlQ6Y4+3J+X7HnsJ9QeMEv4OsYH263fSr0ssCqwuUMQRLG8SxxTQUHiaabaw6wy 7IZGEhoBeFTTFbUQe0FYI5p5Cj1LgVkXzhGD1zfDIQq6Smz9JN+jVfWSujxehZnnXP gi3+a6Ke08C4uJDj4Vecf4YqnrrrBiuAf94dH3/P2w9ETreByxsy1j+xpbsP53sCjC e0mXbozrbFv2A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T9x3G1c7nz9rxF; Thu, 11 Jan 2024 21:24:26 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Thu, 11 Jan 2024 15:11:54 -0500") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277947 Archived-At: Stefan Monnier writes: >> --- a/lisp/subr.el >> +++ b/lisp/subr.el >> @@ -6873,9 +6873,9 @@ version-separator >> >> Usually the separator is \".\", but it can be any other string.") >> >> - >> (defconst version-regexp-alist >> - '(("^[-._+ ]?snapshot$" . -4) >> + `(("^[-._+ ]?hyper$" . ,most-positive-fixnum) >> + ("^[-._+ ]?snapshot$" . -4) >> ;; treat "1.2.3-20050920" and "1.2-3" as snapshot releases >> ("^[-._+]$" . -4) >> ;; treat "1.2.3-CVS" as snapshot release > > Relying on a change in `version-regexp-alist` open a can of worms. Out of curiosity, what are you thinking about? I know this is a hack, but the way I though about it, it should work. > It's much simpler to make sure the GNU ELPA `compat` package uses > versions of the form `30.0.NN` (or `30.1.NN` if it means it > offers functionality from Emacs-30.2, tho hopefully we'll never get > there). This would also be an acceptable fallback strategy IMO, with the minor annoyance that it might confuse some people into thinking that the ELPA package is out of date. >>>>> Is there a place where we could add a warning to make sure that >>>>> bumping the version won't be forgotten? > > The addition cab done procedurally, as in > > ;;;;####autoload (push (list 'compat emacs-major-version > emacs-minor-version) package--builtin-versions) If this work, I like this idea a lot! I'll test it out to see if this could simplify things. > > -- Stefan