From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Thu, 11 Jan 2024 15:07:30 +0000 Message-ID: <875xzzkix9.fsf@localhost> References: <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> <83jzryz6op.fsf@gnu.org> <87a5sugwcx.fsf@gmx.de> <83h6n2z3tr.fsf@gnu.org> <831qe5znrz.fsf@gnu.org> <262ed9fe-b92b-489d-b1f0-5202bfdb088b@gmail.com> <87il7e78j5.fsf@igel.home> <83h6mksaqp.fsf@gnu.org> <87v880jcok.fsf@localhost> <57f6810f-dd98-4cd0-9580-e0f93b8ee158@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lx@shellcodes.org, 66390@debbugs.gnu.org, schwab@linux-m68k.org, Stefan Kangas , michael.albinus@gmx.de, Eli Zaretskii To: Max Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 16:05:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNwcR-00054J-Dd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 16:05:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNwcF-0006Ad-O2; Thu, 11 Jan 2024 10:05:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNwcD-00063O-2e for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:05:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNwcC-0005oO-QZ for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:05:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNwc9-0001sA-RQ for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 10:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.17049854697137 (code B ref 66390); Thu, 11 Jan 2024 15:05:01 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 11 Jan 2024 15:04:29 +0000 Original-Received: from localhost ([127.0.0.1]:33581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNwbc-0001r3-Fu for submit@debbugs.gnu.org; Thu, 11 Jan 2024 10:04:28 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:44267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNwbX-0001qi-8D for 66390@debbugs.gnu.org; Thu, 11 Jan 2024 10:04:27 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D363D240104 for <66390@debbugs.gnu.org>; Thu, 11 Jan 2024 16:04:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704985459; bh=UDGdpI8qU+Iyg/onPeIZXLwRfYcau3Xrbx5De6FeaX0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=p/rN+3b7XKeO1qiYXs8NmOTKbPQ4RCgj+9ziPNaPdMwgcquf6XihCY5I3mTnzFiat TZeIBEjI340eLP+iTVscQTHRZ4sw+f0XBc1EoScfRBiFoNUFmIL8ZMNRKX8wKh1QKF IphWjavnbAkcx/oPZDV754X16eNIkooCifwDFMDR0H/Knsxf5/QfsCDidGMco7fW3U tAQ/4gfpxpt1n5cMfRRUuRLbCWJrdVHI4y+XrtlQVjqHva4taNfqAYUYi1Sw/yjdDn mnO/XsDXYjsuyih5PsmTYIM9aO+n+leq2Etl2RiXXgb8Vi9+GYsxHzLF4v+v3r7xhw FjlYR47A4DRDg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T9nxt3wydz6ty5; Thu, 11 Jan 2024 16:04:18 +0100 (CET) In-Reply-To: <57f6810f-dd98-4cd0-9580-e0f93b8ee158@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277902 Archived-At: Max Nikulin writes: >> Fixed, on bugfix (for the next Org bugfix release). >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bc3caa8f9 > > Ihor, I am confused by `org-man-store-link' call in > > (if (org-man-store-link (equal (Man-translate-references ";id") "\\;id")) > > Is it intentional? I hope, the following is not an issue: That was a typo. I fixed it in https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6b60b5ac12814f0b54209cb6417f9ad1709dce20 > (let ((system-type 'ms-dos)) > (shell-quote-argument ";id")) > "\";id\"" > > no "\\;id" I took this test from the tests introduced in https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=820f0793f0b Stefan, do I miss something or will the tests fail in Dos/Windows builds? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at