From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sat, 27 Jan 2024 16:05:20 +0800 Message-ID: <875xzfkxq7.fsf@yahoo.com> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, dev@rjt.dev To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 27 09:06:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTdhk-0004aG-Vh for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Jan 2024 09:06:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTdh2-0002GU-Pm; Sat, 27 Jan 2024 03:05:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTdh1-0002GK-0g for emacs-devel@gnu.org; Sat, 27 Jan 2024 03:05:35 -0500 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTdgz-0006bB-KV for emacs-devel@gnu.org; Sat, 27 Jan 2024 03:05:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706342731; bh=oEl9cqWmQ26GbKR0AaD0CtzRZ82dhRgxRZLY0as6Wh4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=FFHOoM8pwKBB5xyinTfi7CL2yiy6BgxNhw0zpx+wRJWMl3ulENjyWI/YDzYcg6IBZltKht6DU7fx0BJL+aIOi/5CCA+7izAuIWGqhHmWos+aj3zKsDhMAp/QvGWptI+bdRWueocWy2yJQHxXawh0VLeJms16rjePPogrkfD/uvOtGjnO3OZwFdSuHXfretMalMhEM2OMycORry1Mlr91+tWTXEN3wu4NzQRbGtwD9D/DpdpQlhVePTXQyPah7xkbhGJA20jD4PfaXM/eKgaoErIMtahVHtkW9hK1ApiiJJQqQhMQ2b8XfSRKTj3HBMqfMwzSbKsvqaniVBh6/fyYGw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706342731; bh=pff07UpIwZ9ZTv6VSJqEyGbJGaIftaOT2SxUzyZ+FCH=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Uv1Y+ub4O/N53Hj9o5i5p16x6HtZ3S9nufvuejZnD+5pnGpHaIMOXtLaRYHwmgPhcSWyK+Bw4C9GLL8pTwZfIId/LKshSlxnTVGGU7/AIfIkKpAPBahPZFWqgYRyoWR6zChOHCgwfU7UOYYre03zXa1GOnAHTt9E76oyeHUc+Evmq44GQmH7iRHMFoCC5N3djI5kwG9ydQ4Eh3Lh+VKraOFQj86+IYQ/o4RD5CsPJc9s0pYrnHufh+Z0uL0B8wYXMhNbDWuvUcz75h4nIccx/A/GDe5NyRt3gIkgINE39TA9OiIfDRlITsRqLpnZjjSsMQhk1D6fPBEO6kQ0YrR1xg== X-YMail-OSG: DxXhVa0VM1kEkfRuFo_x4jnQ7gj3M4sD_NzwuovQBUEjG_0kVN.q89iMGQwOTNX LstbWfuGjlOKikNwEwzvSrX0KzenKWB1jG2w3onGG0MzP5UWaCrn.wWpd8i27k78qZ16pANKgHNs 6PxoIe9h_KD0ZR0snzv.V8P2Jso301tpgFhWGK1TIuDzUCMOs1Sd.vwM8e3p7ySIWA53t3lM5Djk 2MEdm4d3qqkcY47O1R0yHlJtKAzOD1nWRGGBFAEHWjwPwA8kRzncKQszR4Y9BIavsPXbcHALDNjK hiGoISjupB..3M7DRxAkJt1kqUDwzhgBiCp3BcAf7giAkZDFnuwj_EtpuFBEjc.m7FXQrXg1Um_W 8XEkyl2oepGCGxeWajF3sOqbtCYE3RDB1lwzfc_9zp6yNGCR8aU74S8WKICQs4oliMc8KgT.I1bm 50Ec7TtziKAalnTKPXzO6KkU9oIV2aG_rHZj9eQEPnRM3dlM9VfDyIiFLiUM9e9pozuxh7XAO78l VwFxxwDP5TLxjuK_PxwXHkjmx7pOmprxNxDrPAO0rxUGu7I7mPRpTZwyJfZ7vjy1qQ5.88H8GW.G vOUNiejZ4w5V3IqS85CcxRShWtA65LzjivgA_X0JL56y0mvHKGIY4Ohi1I64LSzx8_MzmqYWN2sU N2VUH4hpNKrp9H6Ufnj0b7TSH6alGhuHvb1DdP8AF1TDhdFiZ9h7iLJH72rh4rEwuIIVsJkYCkpm aUcCo7j1cfX8JR1tuDL3Mrr82IirZn4mTQQm4nL.YZS2eOEt.aOuXpn4bstth6fugA0aDEwch0XP PP9W3eG0hBs2cFk1vlMfcK0is6P.TzpjT8s2A3nOjE X-Sonic-MF: X-Sonic-ID: c6ec5a3c-95cd-458d-97ea-d191de9035e2 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sat, 27 Jan 2024 08:05:31 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-ddr5z (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 20ac29a343086c9c7aa9133cf5f8f6eb; Sat, 27 Jan 2024 08:05:26 +0000 (UTC) In-Reply-To: <868r4b9qjs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2024 09:35:51 +0200") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.146; envelope-from=luangruo@yahoo.com; helo=sonic304-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315469 Archived-At: Eli Zaretskii writes: >> Why was this installed on emacs-29? It is no bugfix. > > Bug#68708 claims that this is a bugfix. ??? That is a Coreutils bug. But I see bug#68705 in the bug tracker now. > Btw, Yuan: please always mention the bug number in the commit log > messages. If you install someone else's change via "git am", and the > author didn't mention the bug number, please use "git commit --amend" > afterwards to add the bug number (or modify the log message in any > other way), before you push. Yes, please. Furthermore, if such bugfix cannot be described as anything but a simplification (with a correspondingly large diff), there should be another approach safer for the release branch. Quoting Yuan's response on the bug tracker: > Thanks Randy, pushed to emacs-29 since it includes a fix. > > Yuan Our basic criterion for installing patches on emacs-29 is not whether a change contains a bugfix, but whether it runs a risk of destablizing the branch. It is more important that a bugfix be the only component of a change, since that reduces the probability of unanticipated disruption.