all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Steven Allen <steven@stebalien.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69019@debbugs.gnu.org
Subject: bug#69019: [PATCH] package-vc: scan the correct directory for lisp files
Date: Sun, 11 Feb 2024 22:46:51 +0000	[thread overview]
Message-ID: <875xyu39gk.fsf@stebalien.com> (raw)
In-Reply-To: <87zfw7xj3r.fsf@posteo.net>


>> Following up on my previous patch (Bug#68761), we need to scan for
>> package requirements inside the lisp-dir (if set), not in the root
>> package directory.
>
> Looks good, do you have any specific examples where this caused
> problems?

pdf-tools puts all its files in a "lisp" dir, so they weren't getting
searched when scanning for dependencies. The package definition is:


    (:url "https://github.com/vedang/pdf-tools/pulls"
     :lisp-dir "lisp")

This patch causes package-vc to scan for dependencies in elisp files in
"$pkg-dir/lisp/", instead of looking for elisp files in "$pkg-dir/".

>> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1):
>>   Scan 'lisp-dir', if set, for lisp files instead of scanning the root
>>   package directory.
>
> Just note that the convention of the commit message logs is not to
> indent the lines here.  I can take care of that.

I did not, thanks!





  reply	other threads:[~2024-02-11 22:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10 18:51 bug#69019: [PATCH] package-vc: scan the correct directory for lisp files Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 12:48 ` Philip Kaludercic
2024-02-11 22:46   ` Steven Allen [this message]
2024-02-12 17:45     ` Philip Kaludercic
2024-02-12 18:07       ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 21:07         ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xyu39gk.fsf@stebalien.com \
    --to=steven@stebalien.com \
    --cc=69019@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.