From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Fri, 23 Feb 2024 23:07:24 +0000 Message-ID: <875xyeojwu.fsf@jeremybryant.net> References: <871q9rvqbi.fsf@jeremybryant.net> <87mssc65y8.fsf@posteo.net> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37717"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 24 00:26:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdevx-0009Y0-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Feb 2024 00:26:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdevV-0008Gb-5Z; Fri, 23 Feb 2024 18:25:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdevF-0008GA-1O for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 18:25:43 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdevC-0008Ga-Mj for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 18:25:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdeva-0001jp-DZ for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 18:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Feb 2024 23:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.17087307246580 (code B ref 68929); Fri, 23 Feb 2024 23:26:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 23 Feb 2024 23:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:53242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdeuw-0001hx-60 for submit@debbugs.gnu.org; Fri, 23 Feb 2024 18:25:23 -0500 Original-Received: from out-177.mta1.migadu.com ([95.215.58.177]:18209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdeiJ-000150-Sa for 68929@debbugs.gnu.org; Fri, 23 Feb 2024 18:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1708729909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbDQHUH05lh/+I9pcIu4yEK8LwcAfwzA+2w4w3SSgTw=; b=ogMj2zuOSAg7C/gL31o7u0ZnXBdKwr4Bm2vEbTUI6QrtoLqD+w4ACFk+c6UKsJhlOI9Xs9 cBv1ZOGeWM9DaGTRynUv3CTXEOeFrGGOzNtzp+i3sLds6UbzvAD5myefHYwXHMjSrM+7Yf vp+hQvsw+t5IKgASJlQWgy4pgUl2CbAZwINLip4SFcuygjMt3XChKODwB+S1KZ2LqrxGKE XLO3mnS2NHKBhH/hhygeIVNx6NpY21D47ag7xk99vXjAbYIgd82M9+kiQRxqwDEES62UE5 z6Y6TnaASP0e7VRESZJpg7U+0CKq9qY9QIXYyTIjnMYRQs5s+oRWrvMVKzxgtQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87mssc65y8.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280518 Archived-At: Philip, Going through your suggestions, progressing upstream. Philip Kaludercic writes: >> +(defvar which-key--ignore-keys-regexp >> + (eval-when-compile >> + (regexp-opt '("mouse-" "wheel-" "remap" "drag-" "scroll-bar" >> + "select-window" "switch-frame" "-state" >> + "which-key")))) > > regexp-opt is marked as pure, you don't need the eval-when-compile here. > Please clarify your request? It would seem The manual has a similar example to the original code.=20=20 (elisp) Eval During Compile If you have a constant that needs some calculation to produce, =E2=80=98eval-when-compile=E2=80=99 can do that at compile-time. For = example, (defvar my-regexp (eval-when-compile (regexp-opt '("aaa" "aba" "abb")))) What am I missing?