Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu'

[Michael Albinus <michael.albinus@gmx.de>]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

Hi,

> branch: master
> commit babe6a5e948985f961ffd36f64323950abd98b7f
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
>     Introduce a new TRAMP method `androidsu'

You are aware that Tramp is a package on its own, maintained outside the
Emacs repository? I would have appreciated if you had contacted the
maintainer prior pushing such substantial changes. And you make it hard
to decide, whether your (architectural) approach is best suited, now
that it has landed already in Emacs master. At least pushing to a
separate branch would be required. Even better, if this process happens
in the Tramp repository.

I will review your code. Note that it might take a while due to my
restricted availability.

Michael.