all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Arsen Arsenović" <arsen@aarsen.me>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel <emacs-devel@gnu.org>
Subject: Re: missing lexical-binding cookie warning when loading .el files
Date: Sun, 05 May 2024 16:28:07 +0200	[thread overview]
Message-ID: <875xvsib9k.fsf@aarsen.me> (raw)
In-Reply-To: <3CE5D456-0207-41E3-BACF-4DE448666793@gmail.com> ("Mattias Engdegård"'s message of "Sun, 5 May 2024 16:13:24 +0200")

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi Mattias,

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> I'm back-pedalling on this warning: in particular I underestimated the
> amount of little glue files (autoloads, subdirs.el, etc) that users
> have. Almost all of these, and most of the other files, will likely
> work without change when the default is changed to lexical-binding, so
> let users worry about that then.

May I propose emitting it only when there are variables whose scoping
would be changed by it?  IMO, this warning is a reasonable one, but
there's also lots of glue files where it doesn't matter.

IIUC, the heuristic for that shouldn't be very hard to get right (but I
am also not fully aware of the lexical-binding semantics so I'm not
certain).

Have a lovely day.
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

  reply	other threads:[~2024-05-05 14:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 17:28 missing lexical-binding cookie warning when loading .el files Mattias Engdegård
2024-05-03 17:59 ` Eli Zaretskii
2024-05-03 19:41   ` Mattias Engdegård
2024-05-04  3:41     ` Po Lu
2024-05-04  4:18       ` Po Lu
2024-05-04  4:40         ` Po Lu
2024-05-04  7:32           ` Eli Zaretskii
2024-05-04  8:10             ` Po Lu
2024-05-04  8:19               ` Eli Zaretskii
2024-05-04  8:23                 ` Po Lu
2024-05-04  9:05                   ` Eli Zaretskii
2024-05-04  9:22                     ` Po Lu
2024-05-04  9:24                     ` Eli Zaretskii
2024-05-04 10:31                       ` Mattias Engdegård
2024-05-04 12:59                         ` Eli Zaretskii
2024-05-04 16:22                           ` Mattias Engdegård
2024-05-05 14:13                             ` Mattias Engdegård
2024-05-05 14:28                               ` Arsen Arsenović [this message]
2024-05-05 14:58                                 ` Mattias Engdegård
2024-05-05 16:22                                   ` [External] : " Drew Adams
2024-05-05 14:44                               ` Po Lu
2024-05-04  9:47             ` Mattias Engdegård
2024-05-04 10:01               ` Po Lu
2024-05-04 16:54               ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xvsib9k.fsf@aarsen.me \
    --to=arsen@aarsen.me \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.