From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70594: 30.0.50; Error when tabbing with only one active widget Date: Sat, 25 May 2024 11:30:01 +0200 Message-ID: <875xv29r3a.fsf@gmx.net> References: <87r0esl2f5.fsf@gmx.net> <86y190xj4a.fsf@gnu.org> <86y18j78ke.fsf@gnu.org> <867cfi1gnq.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: maurooaranda@gmail.com, 70594@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 11:31:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAnkF-0004ti-6v for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 11:31:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAnju-0004f0-KU; Sat, 25 May 2024 05:30:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAnjr-0004Z4-VQ for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:30:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAnjr-0003qV-Ji for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:30:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAnjz-00054B-0X for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:31:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70594 X-GNU-PR-Package: emacs Original-Received: via spool by 70594-submit@debbugs.gnu.org id=B70594.171662941819443 (code B ref 70594); Sat, 25 May 2024 09:31:02 +0000 Original-Received: (at 70594) by debbugs.gnu.org; 25 May 2024 09:30:18 +0000 Original-Received: from localhost ([127.0.0.1]:42345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAnjG-00053X-1K for submit@debbugs.gnu.org; Sat, 25 May 2024 05:30:18 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:43643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAnjD-00053O-P7 for 70594@debbugs.gnu.org; Sat, 25 May 2024 05:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1716629402; x=1717234202; i=stephen.berman@gmx.net; bh=fPkXp8XJZBGgevSoBIzEECvhF5U1PoB6F4hvM8X1u1o=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=BSZ+iMcbZJKHqLx3/oNl1I6iey1L/0EZc8hRmPRABNryjgficlya9jVk5yDl9oAL 5bn1Tg6vO7VeIdMbTsPprEWPudmbyg2Y0b3l7YHoM3/oemH7snbAlflGBbaM1bAJJ SiLu9X98ZK0XGZXZAgkWi2Z6EYfKilwepy5ewdxCg6JhT1HUIhdr/3L2eyhRwvgrj LClSQuSrskgxdT36GAyvNKlsEBNTUX0bhzqNH74Oq+QxzseatfXmsZh5yl6RAPFjt dfbmoUQtWY/SaGxTKxeQWsGHdcukRmqclF9DYXBK+u9J4Y5FpIfieE1xUvDl9+Ryw b81KStn/Pyw+eK8zsQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.95.181]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M89Gj-1s6gqv06CJ-005EuX; Sat, 25 May 2024 11:30:02 +0200 In-Reply-To: <867cfi1gnq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 May 2024 10:42:33 +0300") X-Provags-ID: V03:K1:7gHJNgbMV5a8MlegjDwk8AIRgGTvl77JgxgZnAllwwpZFx+K10h Pm5G8kIYHuoDC7A8D5cQb5KRVEFL3bp6vKgg80joQmQvuREM5lB6E8aFjmgeg2tOb91vnB2 JsXDLUCoA+W+4wmarCSvjHfR+xEWVosEyd3xoAT7nCNYYBpf+2wA260Gy1b5eJY1gkzMAKo aJinN8OgoH0LKwSZzTtKw== UI-OutboundReport: notjunk:1;M01:P0:78XDI92XEdI=;2Q2//MF0t7l3jkKjZJcxTcmOQ1X lSerN6Zh1sYxhVZcPFwKKlY70RcHe+H1pd6RA0sda9dXW2VOcGjSaA4QcaD64jE3NlCMdEKeo g6QrJ3ug9y5kwsxZisB0LByZ9SbrKJPUBOYzaiQsFUK+/djjUDDziTOSLG6i/xPDcfG0cvT2S LzegY4k97x/W6I3JoXzyfhH2ROU87m7uPRk+KZ5d4O/KSoDGaqQbBaTyGl2uPlbGskMEeka/A NP5D3gSLqKhxkZF2UiteJgwKNCIunL74BrkMeNT1NXfENqVpMM9Eqv4lBccbVBKwZq4A3Zwb0 9JzLI4ZCFYjSdVdh2i31EglEK5Vl2//Pq1wkNfqDETR65XzLnSZdeI2/A3/5RrTHa/aaoKVbZ ioQ0+tgKbSK0YLQQwdzbQBZXobPapXeBi99r6evposb2BQulImAPHJ+Wkvt5UvVCz108sK3KZ M7ANRCAKIPJfjR6nrx1FSUm5CRlYQsRhxHSBvHLVk0D9aJyjSlJUMR2MkItGQTh+nY2w0O7FP EOemsR/UqnmVFceLaXORCgE3ZzN/s906KVKI9f2ovwLWH7xAkmI9aXYqg2EzFuuc1DmoIn38t dAdb2ZhGuA2IrwvWLGfE9K+j8MRk9CRnfDARKGhqGQE0LM7RJntNNNShSRuQAEt90E47tzAcy p/Th8B1KeVgNDwyE6eeuddpr7DCIAJa0jFtDKoZEn3+xAhWFqlU3iur8fCJdViQ9ET1UWPDmW JIF+iE2uV/V7VWpVVe/0F0XMdvnxd3wBUrD17/MeUMfUnObVWhT0DbGbxuThbOYbuqvwiPh7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285848 Archived-At: On Sat, 25 May 2024 10:42:33 +0300 Eli Zaretskii wrote: > Ping! Ping! Can we please make some progress here? Since the patch fixes (according to me testing) a clear bug, either the patch should be installed (or a better one, if someone comes up with one) or commit 91333dacfa1, which introduced the bug, should be reverted; my preference is to install the patch. Steve Berman >> Cc: 70594@debbugs.gnu.org >> Date: Thu, 09 May 2024 10:23:13 +0300 >> From: Eli Zaretskii >> >> Ping! >> >> > Cc: 70594@debbugs.gnu.org >> > Date: Fri, 26 Apr 2024 18:02:13 +0300 >> > From: Eli Zaretskii >> > >> > > Date: Fri, 26 Apr 2024 14:43:42 +0200 >> > > From: Stephen Berman via "Bug reports for GNU Emacs, >> > > the Swiss army knife of text editors" >> > > >> > > Commit 91333dacfa1, which adds the feature of optionally skipping o= ver >> > > inactive widgets when tabbing (bug#70413), fails to handle buffers = that >> > > contain only one active widget; in that case, pressing TAB or S-TAB >> > > raises the error "No buttons or fields found". To reproduce: >> > > >> > > 0. emacs -Q >> > > 1. Load the attached file widget-test.el and then type `M-x >> > > my-widget-test'. >> > > 2. In the buffer "*My Widget Test*" repeatedly press TAB and S-TAB = and >> > > observe that point moves successively between the active radio >> > > buttons labelled "One" and "Two" and the active push button "Sub= mit", >> > > but skips the inactive push button "Reset", since the user optio= n >> > > widget-skip-inactive is enabled. >> > > 3. Now press (via RET or mouse-click) the "Submit" button, which ma= kes >> > > the radio buttons and the "Submit" button inactive and the "Rese= t" >> > > button active. >> > > 4. Pressing TAB once moves point to the "Reset" button, then pressi= ng >> > > TAB again moves point to BOB and raises the error "No buttons or >> > > fields found". Likewise, pressing S-TAB once moves point to "Re= set", >> > > then pressing S-TAB again moves to EOB and raises the same error= . >> > > >> > > The attached patched fixes this bug. In addition, when only one wi= dget >> > > is active and point is on it, since pressing TAB or S-TAB does not = move >> > > point, the informational message "Only one tabable widget" is displ= ayed. >> > > >> > > The original code in widget-move contained separate loops to handle >> > > forward and backward movement and this involved some code duplicati= on. >> > > The changes to this code to fix the bug would have required further >> > > duplication, so I took the opportunity to parameterize the >> > > directionality, allowing handling both directions in a single loop. >> > > This shortens the code and IMO makes the similarities and differenc= es in >> > > the handling easier to see. >> > >> > Adding Mauro to the discussion. >> > >> > >> > >> > >> >> >> >>