From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Adding new package hideshowvis to nongnu elpa Date: Sun, 02 Jun 2024 19:45:18 +0000 Message-ID: <875xurdt81.fsf@posteo.net> References: <807D0D50-1A4C-4A83-9807-DB7A50EC60AA@sheijk.net> <87cyp55b9l.fsf@posteo.net> <4EA8DCA4-0BC4-4E88-B481-DE12E17DDAAE@sheijk.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17969"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jan Rehders Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 03 07:12:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDzzo-0004Tb-Jh for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jun 2024 07:12:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDzyn-0007yl-Md; Mon, 03 Jun 2024 01:11:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDzyl-0007yG-Rw for emacs-devel@gnu.org; Mon, 03 Jun 2024 01:11:32 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDr8s-0000vt-8H for emacs-devel@gnu.org; Sun, 02 Jun 2024 15:45:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C0BDE240104 for ; Sun, 2 Jun 2024 21:45:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717357519; bh=0t0kcGStEgjzRI3MGQt3MV5Sp5BDCbW1E5pEG5C7nbM=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=AVa/wlNBfYGovc46kqTOMrpmtJVY+FgqTab0h4YtM6FljLCYzT4dhG+UCGbs1qn1X ij50d3zvJI+SKZ4E4RkImhotqfu8PkjDpjYYK7owTyO5AP3umZ5xeKsjlhnXkzSO69 tkuG5rjeFdlm7zpi5HCa3W38j411nPRjoAukiqMFpxEplVsQlzJmudKeaTOg1iFlXL qy8eB5E1FNF582Yp0PySHTXO2no+rBpnM1LPGRsW8dOkrM+QZmcWfh56+IlwChaQGw p0fp+Wvgx3P0xpo3654dUO9/sUJLMV0SF2hAId2IFhv0yzGTOgLK+JFMNMNzYliPme 24Xpp/7tBtH0Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VsnQ71fJJz6tvk; Sun, 2 Jun 2024 21:45:18 +0200 (CEST) In-Reply-To: <4EA8DCA4-0BC4-4E88-B481-DE12E17DDAAE@sheijk.net> (Jan Rehders's message of "Wed, 29 May 2024 13:35:04 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319787 Archived-At: Jan Rehders writes: > I=E2=80=99ve applied your improvements, thank you! > >> Are you sure you don't want the package to be added to GNU ELPA? > > If that requires copyright assignment then I=E2=80=99m happy to do that b= ut > maybe at a later time. I=E2=80=99m not sure I have the time+energy to do = that > and check if any contributors submitted more than a few lines right > now No problem, I just wanted to make sure that you were consciously deciding to submit the package to NonGNU. >> (defun hideshowvis-remove-overlays () >> "Will remove all overlays added after calling `hideshowvis-symbols'." >> - (when (equal hs-set-up-overlay 'hideshowvis-display-code-line-counts) >> + (when (eq hs-set-up-overlay #'hideshowvis-display-code-line-counts) >> (dolist (ov (overlays-in (point-min) (point-max))) >> - (unless (null (overlay-get ov 'hs)) >> + (when (overlay-get ov 'hs) ;why are you returning a `hs' here? >> (overlay-put ov 'after-string nil))))) > > Not sure I understand the question - I don=E2=80=99t intend to return > anything. I=E2=80=99m using the =E2=80=98hs property added by hideshow.el= to identify > which overlays need to be changed to not break other highlighting > packages. Ugh, my bad I misread the line and thought to have read (dolist (ov (overlays-in (point-min) (point-max)) 'hs) ...) Sorry about that. >> You can track files to ignore in a .elpaignore file as well. That might >> be better, in case you decide to replace, rename the file or add more. >> I can change that for you, you just have to add the file to the >> repository. > > This seems like a good idea, added .elpaignore to the repo 1+ Is there anything else that we should discuss before adding the package to the archive? --=20 Philip Kaludercic on peregrine