bug#71264: 30.0.50; Dired deletion moves point under auto-revert

[Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I think we should install this, but byte-compiling it produces a
> warning:
>
>   In dired-internal-do-deletions:
>   dired.el:4021:28: Warning: Unused lexical variable `auto-revert-mode'
>
> Can you fix this and resubmit?

Thanks Eli.  Here is an updated version of this patch.  I also removed
the setting of `dired-auto-revert-buffer' that has nothing to do with
this bug and added a reference to the bug number in the comments.

> Also, I presume all the Dired tests in the test suite still pass after
> the change?

I have attached the following logs: dir-tests.log, dired-aux-tests.log
and dired-x-tests.log.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Prevent-auto-revert-when-deleting-entry-bug-71264.patch --]
[-- Type: text/x-patch, Size: 1409 bytes --]

From b4b3e32a7f1375ff228bc25311a56062d64aa049 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Mon, 17 Jun 2024 11:06:28 +0200
Subject: [PATCH] Prevent auto-revert when deleting entry(bug#71264)

* lisp/dired.el (require): Require "autorevert" for
`auto-revert-mode' usage.
(dired-internal-do-deletions): Temporarily prevent auto-revert.
---
 lisp/dired.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/dired.el b/lisp/dired.el
index c51e5e42c29..0adf06f471e 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -36,6 +36,7 @@
 
 (eval-when-compile (require 'subr-x))
 (eval-when-compile (require 'cl-lib))
+(eval-when-compile (require 'autorevert))
 ;; When bootstrapping dired-loaddefs has not been generated.
 (require 'dired-loaddefs nil t)
 (require 'dnd)
@@ -4015,7 +4016,11 @@ dired-internal-do-deletions
               (dired-move-to-filename)
 	      (let ((inhibit-read-only t))
 		(condition-case err
-		    (let ((fn (car (car l))))
+		    (let ((fn (car (car l)))
+                          ;; Temporarily prevent auto-revert while
+                          ;; deleting entry in the dired buffer
+                          ;; (bug#71264).
+                          (auto-revert-mode nil))
 		      (dired-delete-file fn dired-recursive-deletes trash)
 		      ;; if we get here, removing worked
 		      (setq succ (1+ succ))
-- 
2.45.2


[-- Attachment #3: dired-tests.log --]
[-- Type: text/plain, Size: 2146 bytes --]

Running 16 tests (2024-06-17 11:19:04+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
   passed   1/16  dired-autoload (0.000141 sec)
Marking matching files...
Checking /home/manuel/emacs-repo/test/bug22694/test
1 matching file marked
   passed   2/16  dired-test-bug22694 (0.085776 sec)
Copy: 1 of 1
Copy: 1 file done
Copy: 1 of 1
Copy: 1 file done
   passed   3/16  dired-test-bug25609 (0.034042 sec)
Saved pos: ((#<buffer emacs-test-tp9Za3-dired> nil 4) nil nil)
Saved pos: ((#<buffer emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4) ((#<window 1 on emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4)) nil)
Saved pos: ((#<buffer emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4) ((#<window 1 on emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4)) nil)
Saved pos: ((#<buffer emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4) ((#<window 1 on emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4)) nil)
Saved pos: ((#<buffer emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4) ((#<window 1 on emacs-test-tp9Za3-dired> "/tmp/emacs-test-tp9Za3-dired/test-subdir" 4)) nil)
   passed   4/16  dired-test-bug27243-01 (0.042852 sec)
   passed   5/16  dired-test-bug27243-02 (0.041971 sec)
   passed   6/16  dired-test-bug27243-03 (0.094497 sec)
   passed   7/16  dired-test-bug27631 (0.013950 sec)
   passed   8/16  dired-test-bug27940 (0.086650 sec)
   passed   9/16  dired-test-bug27968 (0.021243 sec)
   passed  10/16  dired-test-bug59047 (0.037082 sec)
   passed  11/16  dired-test-bug7131 (0.088727 sec)
   passed  12/16  dired-test-directory-files (0.003667 sec)
   passed  13/16  dired-test-directory-files-and-attributes (0.002743 sec)
   passed  14/16  files-tests-bug-50630 (0.010067 sec)
   passed  15/16  files-tests-insert-directory-shows-files (0.009958 sec)
   passed  16/16  files-tests-insert-directory-shows-free (0.010036 sec)

Ran 16 tests, 16 results as expected, 0 unexpected (2024-06-17 11:19:05+0200, 0.585970 sec)


[-- Attachment #4: dired-aux-tests.log --]
[-- Type: text/plain, Size: 729 bytes --]

Running 5 tests (2024-06-17 11:19:04+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
   passed  1/5  dired-guess-default (0.000328 sec)
/tmp/emacs-test-6LIEqx-dired-aux
/tmp/emacs-test-6LIEqx-dired-aux
/tmp/emacs-test-6LIEqx-dired-aux
/tmp/emacs-test-6LIEqx-dired-aux
ls: .//tmp/emacs-test-6LIEqx-dired-aux: No such file or directory
/tmp/emacs-test-6LIEqx-dired-aux
   passed  2/5  dired-test-bug27496 (0.046338 sec)
   passed  3/5  dired-test-bug28834 (0.003451 sec)
   passed  4/5  dired-test-bug30624 (0.023089 sec)
   passed  5/5  dired-test-highlight-metachar (0.000178 sec)

Ran 5 tests, 5 results as expected, 0 unexpected (2024-06-17 11:19:04+0200, 0.074519 sec)


[-- Attachment #5: dired-x-tests.log --]
[-- Type: text/plain, Size: 453 bytes --]

Running 2 tests (2024-06-17 11:19:05+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
Marking matching files...
2 matching files marked
2 marks removed
Marking matching files...
6 matching files marked
   passed  1/2  dired-test-bug25942 (0.025861 sec)
   passed  2/2  dired-x--string-to-number (0.000086 sec)

Ran 2 tests, 2 results as expected, 0 unexpected (2024-06-17 11:19:05+0200, 0.026748 sec)


[-- Attachment #6: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud