From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Thu, 05 Sep 2024 14:35:52 +0000 Message-ID: <875xraw4l3.fsf@posteo.net> References: <87le083m1s.fsf@ledu-giraud.fr> <877cbqjt03.fsf@posteo.net> <87h6auw6sj.fsf@ledu-giraud.fr> <86y1462o7u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7519"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73004@debbugs.gnu.org, Manuel Giraud , Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 16:37:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDbm-0001h7-A7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 16:37:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDbZ-0000L5-KB; Thu, 05 Sep 2024 10:37:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDbW-0000KM-87 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:36:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smDbV-0004F6-Ub for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:36:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=q/AEMdhU3mxHLovAXpGxSUfI14g4+/Ywm4HpUNUNXjA=; b=UPe6LSvFi12TKbgfAWaefvEXODf2q6TxGJWejOzF993WmnRkJ7oVoEYJV34fapIj3orzL0tQDhMeQw86kg5Roen0QR+Zla5TSdsJ8bxrvLFNm0Oywz5GfIuoirPVkXB4tCZYH1HM/LGBj4b1ADEqzDtZxl84h1ZC1rRI0+NZEnTmogIvwP63pCKanXBD9nS9/q3CXzQNPPxdbYWLeD4khUhoz6vo+9aYdnubGNKuYAic+vUZ19QiDtDFaatODl2MTBDIflI3OkjFNaHwUroO0dl/p17w8KpLld0p4TDWzB0+ywdf4AsnZvHQLL9BIHgiNZbWKTzZMRSGJLvAWLSBjQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smDcY-0006dn-1U for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73004-submit@debbugs.gnu.org id=B73004.172554702925324 (code B ref 73004); Thu, 05 Sep 2024 14:38:01 +0000 Original-Received: (at 73004) by debbugs.gnu.org; 5 Sep 2024 14:37:09 +0000 Original-Received: from localhost ([127.0.0.1]:37765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDbg-0006aO-Vt for submit@debbugs.gnu.org; Thu, 05 Sep 2024 10:37:09 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDbe-0006Zo-C5 for 73004@debbugs.gnu.org; Thu, 05 Sep 2024 10:37:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 99117240103 for <73004@debbugs.gnu.org>; Thu, 5 Sep 2024 16:35:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1725546954; bh=FrY9v6+CTBBbdPuIQ8W3uxNhgRO9LFe9lNqERQn6CTo=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=JwUovfG1fZHWpX+P21250ZZJ3ukXZYLT1oqdqX6ArOnI0AHkT2qmQS9FSiSaUO/Uz xxi8Cr5lcR26CQoJ11kdfuWFd7jpySnFHWrdM5eoqPbY7oBHMrQtTU5wvCXVdPqpRB G+0MadxeelvCJ2hc6SMMlL7iX0pzej3f/Y/4Kxu+k9RjUYOJ9ykyzdo4iZdvkEd2AK Ul7L+WvvPCVaIc/CbOYc4rJrchtlYI9cOlY1M2hmJIhFygWvW36hcg9zcKjzgieo6Q 0qgnnypCwYeiYgc8dmS3cXdC5fXI6sZ5R02idBF4NVF67oDNgXA8zdieOa73/SrLQu ZWHpdLhqZu6ag== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X023F3vPJz9rxB; Thu, 5 Sep 2024 16:35:53 +0200 (CEST) In-Reply-To: <86y1462o7u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 17:02:13 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291258 Archived-At: Eli Zaretskii writes: >> Cc: 73004@debbugs.gnu.org >> Date: Thu, 05 Sep 2024 15:48:12 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > And is xdg-open reliably available on BSD systems, so that we don't >> > generate an opaque error message if that is not the case? >> >> I think it would work whether xdg-open is install or not because >> `shell-command-guess-open' is defined by testing the presence of >> xdg-open. So if xdg-open is not installed, `command' in the code above >> will be nil and nothing will happen. > > Then why do we need to condition this by system-type at all? Juri implemented the command, so perhaps he could explain. I don't understand why one doesn't just use `shell-command-guess-open' directly? -- Philip Kaludercic on siskin