From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73004@debbugs.gnu.org, Manuel Giraud <manuel@ledu-giraud.fr>,
Juri Linkov <juri@linkov.net>
Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems
Date: Thu, 05 Sep 2024 14:35:52 +0000 [thread overview]
Message-ID: <875xraw4l3.fsf@posteo.net> (raw)
In-Reply-To: <86y1462o7u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 17:02:13 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 73004@debbugs.gnu.org
>> Date: Thu, 05 Sep 2024 15:48:12 +0200
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> > And is xdg-open reliably available on BSD systems, so that we don't
>> > generate an opaque error message if that is not the case?
>>
>> I think it would work whether xdg-open is install or not because
>> `shell-command-guess-open' is defined by testing the presence of
>> xdg-open. So if xdg-open is not installed, `command' in the code above
>> will be nil and nothing will happen.
>
> Then why do we need to condition this by system-type at all?
Juri implemented the command, so perhaps he could explain. I don't
understand why one doesn't just use `shell-command-guess-open' directly?
--
Philip Kaludercic on siskin
next prev parent reply other threads:[~2024-09-05 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 13:26 bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 10:26 ` Philip Kaludercic
2024-09-05 13:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 14:02 ` Eli Zaretskii
2024-09-05 14:35 ` Philip Kaludercic [this message]
2024-09-05 16:49 ` Juri Linkov
2024-09-06 7:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 7:48 ` Eli Zaretskii
2024-09-18 16:51 ` Juri Linkov
2024-09-19 3:52 ` Howard Melman
2024-09-19 6:15 ` Juri Linkov
2024-09-05 14:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xraw4l3.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=73004@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.