Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R

[Ihor Radchenko <yantar92@posteo.net>]

Jack Kamm <jackkamm@gmail.com> writes:

>> Rather than `t', I'd use something more descriptive like 'disable-prompt-filtering.
>
> Is the attached patch what you had in mind? If so I will squash it with
> the previous patch.

Your variant is even better than what I had in mind.

> But first -- note that the current patch is on top of bugfix. I had
> mentioned this in my original email but want to double check if it's
> OK. In particular, I'm not sure if it's acceptable for bugfix branch
> anymore, now that I'm changing the function signature of
> `org-babel-comint-async-register' (albeit in a backward-compatible way).
>
> I had originally proposed bugfix since I use R's table() function a lot
> (as in my original example), and it was causing me problems when I
> belatedly upgraded my work machine to Org 9.7.  But if you prefer, I can
> rebase onto main.
>
> Another possibility would be to add a hardcoded check on bugfix to skip
> the prompt filtering if the major-mode is R or Python; then on main,
> revert the hard-coded check, and update the signature of
> `org-babel-comint-async-register' to set it properly with a
> variable. But not sure it's worth the hassle -- I might just switch to
> using main branch on my work machine at that point.

I think that it is ok for bugfix as the patch essentially reverses the
commit that introduced the regression for ob-R and ob-python. (The
original patch was fixing a problem with ob-shell). So, that patch is
fairly trivial.

We might want to document the signature change in ORG-NEWS on main
though, as an additional patch for main.

For reference, here is the official policy on bugfix branch:
https://orgmode.org/worg/org-maintenance.html#release-types

> +    (setq org-babel-comint-async-remove-prompts-p
> +          (let ((prompt-handling (or prompt-handling 'filter-prompts)))
> +            (cond
> +             ((eq prompt-handling 'disable-prompt-filtering) nil)
> +             ((eq prompt-handling 'filter-prompts) t)
> +             (t (error (format "Unrecognized prompt handling behavior %s"
> +                               (symbol-name prompt-handling)))))))

nitpick: I'd rather add (eq prompt-handling nil) as a cond clause, to
make it more explicit.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>