From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: New "make benchmark" target Date: Sat, 14 Dec 2024 20:07:38 +0000 Message-ID: <875xnmf2qp.fsf@protonmail.com> References: <87h679kftn.fsf@protonmail.com> <86frmt1k6w.fsf@gnu.org> <871pydjo23.fsf@protonmail.com> <87msh0j12c.fsf@protonmail.com> <87zfkyfqia.fsf@protonmail.com> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , Eli Zaretskii , =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= , Paul Eggert , emacs-devel@gnu.org, =?utf-8?Q?Jo=C3=A3o_T=C3=A1vora?= To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 15 06:43:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMhPV-0005aa-QU for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Dec 2024 06:43:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMhOg-0003IR-LQ; Sun, 15 Dec 2024 00:42:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMYQX-0004K1-TQ for emacs-devel@gnu.org; Sat, 14 Dec 2024 15:07:49 -0500 Original-Received: from mail-10630.protonmail.ch ([79.135.106.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMYQT-0000eC-58 for emacs-devel@gnu.org; Sat, 14 Dec 2024 15:07:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1734206861; x=1734466061; bh=P3GNRR2cxs5V1Ommqvbfd6PHAdIJGovxAtoaLAUu9vs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=fsX5fAojrjRsbjHAKPFDWSe5bwMg1qxcD1R7wz7Q5bZOXckSerJ4CBGdMJ5Qyl+k3 phjJRPhYP8pncsLST94ocfHEtO8SOCu9D1zwEolwgYygwiCjfkJOxSGb3Fgb0frzS7 9rVaQhenbnUeDyj4vQNxjlSx0VY2l6tbzIby+tedrKv/w2oGl1QJRZ7SsjdU9lX8wd Fi+/oVaLM2/c2lAdeRftie9wKFv2uWDSQiWDkN5zjjT99lFRa55R8I7TbYxGra4eIn WQTv66/RMJ4PjKNiYLFCxf/KVmZFDyIvCOu6vrp0CbTRqyBfZn5J+y/CvIL85iWWq9 ig5YLpyDNEUCQ== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 81fd47ee3737e53d193331abc1a7deb6fea0c0f4 Received-SPF: pass client-ip=79.135.106.30; envelope-from=pipcet@protonmail.com; helo=mail-10630.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 15 Dec 2024 00:42:28 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326515 Archived-At: "Stefan Kangas" writes: > Pip Cet writes: > >> FIXME BEFORE MERGING: Should we add a link to >> https://git.savannah.gnu.org/gitweb/?p=3Demacs/elpa.git;a=3Dhistory;\ >> f=3Dbenchmarks/bubble.el;h=3Dd7101b1b99b60a3bd6945909d1f0125215f4ce1c;\ >> hb=3Drefs/heads/externals/elisp-benchmarks >> here? Losing git history because we copy a file from elpa to emacs >> seems suboptimal... > > Instead of copying the file, it might be preferable to import the entire > git history into emacs.git, like we did for use-package and eglot. Then > the old branch on GNU ELPA can be dropped, as we won't lose any history. Just to be clear, dropping the branch in GNU ELPA wouldn't mean that the package would no longer be available, just that it would build signed packages from the main Emacs repo? > Jo=C3=A3o has some scripts that he used for eglot, and I adapted them for > use-package. Note that he also had some copyright assignment issues to > take care of, so it could probably be simplified. > > Please take a look here: > https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770 Thanks for the pointer! I tried getting that to work, and finally succeeded in creating a (local) merged brach, but then I noticed that the commit messages will need editing to conform to the ChangeLog style. We also need to decide on the directory structure; right now, I've created a lisp/emacs-lisp/benchmarks/ directory; I'd prefer lisp/benchmarks (which would make it easier to exclude the benchmark files from compilation), but I don't have a strong preference and others should make that decision. (I haven't included the lisp/emacs-lisp/subdirs.el file, but if we decide to keep the benchmarks in lisp/emacs-lisp/benchmarks/, we'll need to gitignore that, too). There are some byte compiler warnings, which I guess we should fix. I'm not sure how to proceed here. Since there aren't that many commits, I can offer to change the commit messages myself, but I fully understand if someone else (Andrea or another volunteer) wants to do it. I can push the merged branch to a scratch branch of the emacs repo, or you can access the merged branch (without any edits to the commit messages) at https://codeberg.org/pipcet/emacs/src/branch/merge-elisp-benchmarks Joao, I think it would be a good idea to keep the modified script in admin/ or somewhere for future reference, but I don't know whether you consider it an Emacs contribution (and, thus, covered by your copyright assignment). [Political/Software Freedom note: I know that some people on the list don't care, but others do: at least occasionally, GitHub won't let you see a "gist" unless you use a GitHub account. This surprised me (and isn't reproducible now, so it's possible this was a temporary misconfiguration on GitHub's side, but who knows?) and it's another reason not to use GitHub for code sharing.] Pip