From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lin Sun <sunlin7@hotmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
"74881@debbugs.gnu.org" <74881@debbugs.gnu.org>
Subject: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
Date: Sun, 29 Dec 2024 02:49:14 +0100 [thread overview]
Message-ID: <875xn3jm1x.fsf@web.de> (raw)
In-Reply-To: <TYCPR01MB100042551D4F4777D84FB2011FB0F2@TYCPR01MB10004.jpnprd01.prod.outlook.com> (Lin Sun's message of "Sat, 28 Dec 2024 08:04:52 +0000")
Hi,
I'm a bit late, feel free to ignore may comments if you think it's not
worth the trouble.
Lin Sun <sunlin7@hotmail.com> writes:
> +(defun ediff--delete-temp-files-on-kill-emacs ()
> + "Delete the temp-files associated with the ediff buffers."
> + (ignore-errors
> + (let ((inhibit-interaction t))
> + (dolist (b (buffer-list))
> + (with-current-buffer b
> + (when (eq major-mode 'ediff-mode)
> + (ediff-delete-temp-files)))))))
I think this is the same as mapping over `ediff-session-registry' which
should hold exactly the list of buffers we want.
Second: Can we move the `ignore-errors' inwards so that an error in one
case doesn't abort the complete loop?
> ;;; Setup functions
>
> @@ -488,6 +496,7 @@ ediff-setup
> (if (ediff-buffer-live-p ediff-meta-buffer)
> (ediff-update-meta-buffer
> ediff-meta-buffer nil ediff-meta-session-number))
> + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill-emacs)
Would it be ok to avoid the above loop completely by using the buffer
local version of `kill-emacs-hook' instead?
Michael.
next prev parent reply other threads:[~2024-12-29 1:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 5:59 bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Lin Sun
2024-12-15 8:04 ` Eli Zaretskii
2024-12-15 17:25 ` Lin Sun
2024-12-27 5:38 ` Lin Sun
2024-12-27 8:10 ` Eli Zaretskii
2024-12-27 17:34 ` Lin Sun
2024-12-28 7:38 ` Eli Zaretskii
2024-12-28 8:04 ` Lin Sun
2024-12-28 12:41 ` Eli Zaretskii
2024-12-28 17:40 ` Lin Sun
2024-12-29 1:49 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-12-29 2:25 ` Lin Sun
2024-12-30 1:37 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-30 2:07 ` Lin Sun
2024-12-30 22:37 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-04 12:39 ` Eli Zaretskii
2025-01-06 7:15 ` Lin Sun
2024-12-29 7:04 ` Eli Zaretskii
2024-12-29 23:34 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-30 13:02 ` Eli Zaretskii
2024-12-30 22:34 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xn3jm1x.fsf@web.de \
--to=bug-gnu-emacs@gnu.org \
--cc=74881@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=sunlin7@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.