From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pranshu Sharma via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Merge haskell-ts-mode in upstream Date: Mon, 30 Dec 2024 01:10:24 +1000 Message-ID: <875xn28qzj.fsf@bauherren.ovh> References: <87cyhh7t00.fsf@bauherren.ovh> <87msglb89y.fsf@posteo.net> <87ed1s1akm.fsf@bauherren.ovh> <87msgfzsvl.fsf@posteo.net> <87r05rmxhm.fsf@bauherren.ovh> <87cyhazgw5.fsf@posteo.net> Reply-To: Pranshu Sharma Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10162"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pranshu Sharma via "Emacs development discussions." To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 29 16:27:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRvC2-0002Rv-Md for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Dec 2024 16:27:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRvBg-000319-CU; Sun, 29 Dec 2024 10:26:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRuwA-000878-PY for emacs-devel@gnu.org; Sun, 29 Dec 2024 10:10:38 -0500 Original-Received: from mail.bauherren.ovh ([45.32.179.127]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRuw8-0007Cf-8p for emacs-devel@gnu.org; Sun, 29 Dec 2024 10:10:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bauherren.ovh; s=mail; t=1735485031; bh=b2NaY/kZVlFOOMIhHrmPbhphFQ9/rg3tGHr5pgFwivg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qBREOnUGJ2aak97R7z7GA87qQLrBTvG4D/bjrxU4oHaoc910NHWlzkjYVSUR+LYUU GjDmjBet/i+gsjDI3V29SB9D7DpYCpAUhJae0NLDoetPMvVSi0mvB9V8zgZqek4Fst OhEOJAlys1NK/ZU6HM50T2D3fqA13pmMgrCigZYvVKBbzdK4IZ7LN8S+nGjl9ZQ5/F YPoMH0wAYa7t8gM3TfnI7GgxoIbX5QXjwgN87KR3IrvAgNYeT39wdrz/EUMpl/sihm MoV3VwQJNiPPjoZlpe4cOb2iga/rC3pLV5snFlA2UJRVFuyQ9ZBkC2T6xM58+4ZYhb 12iGTXFmRlcKQ== In-Reply-To: <87cyhazgw5.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 29 Dec 2024 14:46:18 +0000") Received-SPF: pass client-ip=45.32.179.127; envelope-from=pranshu@bauherren.ovh; helo=mail.bauherren.ovh X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FROM_FMBLA_NEWDOM28=0.798, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 29 Dec 2024 10:26:35 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327348 Archived-At: Philip Kaludercic writes: >>>>> I see that you have started a new repository. Do you want us to >>>>> mirror >>>>> your changes with all the commit history, or are you OK with us >>>>> just >>>>> copying over the coded periodically whenever you want to update >>>>> the code? >>>> >>>> Ok, it seems like I'll be sticking to git one anyway, since >>>> git-hg-bridge or something doesn't work. I am fine with using the >>>> old >>>> repo. >>> >>> Wait, I am confused. The initial proposal was to add the package to >>> emacs.git, right? >> >> Yes, but iiuc it will still have own repo and emacs will just mirror >> it >> or smth. > > Ok, that is fine. You'll just have to ping the mailing list whenever > there is a new release. > Ok, this sounds better, I would prefer to do this. > [29 lines omitted] >> >> Not really, it is mostly convince for C-M-h TAB, but since it is >> meant ot be >> used a lot, it get it's own special binding. The rules are tiny bit >> different. > > But then my question is why doesn't M-q in Emacs 30 do the same as > well? > If it is invoked in a prog-mode outside of a comment or a string, it > should mark the defun and indent it, or does it not do that for > tree-sitter modes? > Turns out it does, I thought it used M-h instead of C-M-h to find the region to inden. I removed the old function. >>>> I attach new file, I have also pushed changes to codebrg repo. >>> >>> I think it would be someone with more Tree Sitter experience could >>> take >>> a look at the code as well. Perhaps we should make this more >>> formal by >>> moving over to the bug tracker? >> >> Sounds good. > > 1+ Ok, done Thanks again for your inital code reivew and patiant replys -- Pranshu Sharma