From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.bugs Subject: bug#41493: 26.3; Error in MPC directory browser Date: Wed, 01 Jan 2025 21:27:55 -0600 Message-ID: <875xmx7v44.fsf@pub.pink> References: <87pnaue55o.fsf@x1.intra> <87ed1npsbm.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27052"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.1; emacs 31.0.50 Cc: 41493@debbugs.gnu.org, Matthieu Lemerre , Stefan Kangas To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 04:29:39 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTBtx-0006q0-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 04:29:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTBtS-0005Pb-98; Wed, 01 Jan 2025 22:29:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTBtO-0005Oi-TX for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:29:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTBtO-0001SM-Kp for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:29:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=NehYXcru6nYLezHg5+7JaILUZrnk4W5aquuSzbrSLIw=; b=LpdEe7/9F1ktq/49FY4tsr/ZHZFB3anF62uOWFFpJ6Klvi5AGjieAlD13almfYt9Oo9NkeyRob+6kZ4e46S8rvjEHPdEii/hy7XLzWZ0Hob5oePxpwynCYuk1UGYWs7rCBtDcUpDxGxzpSzw13wMBf9EKKTfYGxDhrQsHec1u+UoNw2JLvCmuoAQrrD0z6AIKC6SRb3N0j0zf6XAJJ8c30Tjw2ovTZa9KjA5nJMw30/Jnnmqn8F8eh/hW1M/480Kl5q206tZHhQmoddHNA0oP0BEmfAJtfi7yzqz86QO12GhcH3kCWHUcS1xIe3ESb7xrWYPc6fQ03yOkUu3BI1TtQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTBtO-0006Ze-DV for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 22:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41493 X-GNU-PR-Package: emacs Original-Received: via spool by 41493-submit@debbugs.gnu.org id=B41493.173578850425202 (code B ref 41493); Thu, 02 Jan 2025 03:29:02 +0000 Original-Received: (at 41493) by debbugs.gnu.org; 2 Jan 2025 03:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:41677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTBsl-0006YQ-Iv for submit@debbugs.gnu.org; Wed, 01 Jan 2025 22:28:23 -0500 Original-Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]:36251) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTBsi-0006YB-Fo for 41493@debbugs.gnu.org; Wed, 01 Jan 2025 22:28:21 -0500 Original-Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 848BC254017C; Wed, 1 Jan 2025 22:28:13 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Wed, 01 Jan 2025 22:28:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1735788493; x=1735874893; bh=NehYXcru6nYLezHg5+7JaILUZrnk4W5aquuSzbrSLIw=; b= sIVVst76HRhluj3caap8Qdh0WugLvy4J6XqizSMkXjb/c+AAjVV6MjfO4y13cv7x 64zzyoXJP3fXnaXNYad9iJdenxXkzQiXLR6ORHs6t80YYQ252ah0hCeZGPEo5iWO OqfQxieqxDS4nR27NjlzGfESalhczzkvHlJUiBkcleTC9TSyofzbMoZ5PJ/W3IKf DCUJDs1q6PP5GEuUplBh9VfUHWw5pfUE5TuJ1ZGy36nfK+WAr51mdW3z1Wvq+SZU ujbwQOv80+KB1KmfYLptzC4U+0w9gGoNNi3QNkY+njjQjyXYHapLFJ/jJSkAMcVs UhT6DwbEtrsoLvjoSxQxSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735788493; x= 1735874893; bh=NehYXcru6nYLezHg5+7JaILUZrnk4W5aquuSzbrSLIw=; b=I 7ARtk+4E/tB8KY2ZDrqHVV6nJ7m7DQfkT76heXs0K456xtPZ8dbilOOAg485di5+ 3w2t5agu3JnUTaBzRYTumaZLXhzNgkU5xl9kmmk5YLn/3064lD1aGdj2c/QogxWI fCYCNlY8DSnbKC9LDYA9v5w76JuZoSQAjZW2fCDgk7i5QqVhdWO0fgRsNxoXl/UM 9XH2HWx+Q+7pSbOflz7wWwWv/1ZRuygLLdIzwNsKxrk6LghYpJX195kL0RQTkuef NNxBJaitLAZZtv0llPNIWwUp/Fg7CaWTCloDad4pL70V+f5ispyhDFVPOuVv1VOj rAblK80SjR20Vf2if7XXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudefuddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreej necuhfhrohhmpehjohhhnhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrf grthhtvghrnhepgeevhedvtdetvdekuddvtddthefhvdfggfdvgfeitdejudehhfffjedt vdevveeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epjhhmsehpuhgsrdhpihhnkhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphho uhhtpdhrtghpthhtohepgedugeelfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtph htthhopehrrggtihhnsehfrhgvvgdrfhhrpdhrtghpthhtohepshhtvghfrghnsehmrghr gihishhtrdhsvgdprhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrg hlrdgtrg X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jan 2025 22:28:12 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Wed, 01 Jan 2025 13:22:01 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298110 Archived-At: Stefan Monnier writes: > Hi John, > > Hmm... IIUC the output we receive is a list of pairs made of sublists of > the form either: > > (directory . <...>) > (Last-Modified . <...>) > > or > > (file . <...>) > (Last-Modified . <...>) > (Format . <...>) > (Title . <...>) > ... That=E2=80=99s what I see in the (fairly recent) versions of mpd I tried. > IIUC when I wrote the code there were no such `Last-Modified` entries. > > We're interested in extracting a list of the files (where each file is > represented by its alist), so I just stripped away all the `directory` > entries and that was it. But now that `directory` can be followed by > info about that directory (currently only `Last-Modified`), we should > arguably be more careful to also remove everything between > `directory` and the next `file` or `directory`. > > So I think the patch below is "more robust". > WDYT? Yeah that makes more sense. > I also think it's a good opportunity to add some comments/docstrings > because it took me a while to understand what this was trying to do. No objections from me :)