Re: Adding git-commit highlight mode?

["Arsen Arsenović" <arsen@aarsen.me>]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 02 Jan 2025 22:07:46 +0300
>> 
>> On Thu, 2025-01-02 at 21:01 +0200, Eli Zaretskii wrote:
>> > Do you plan to make this mode be descendant of change-log-mode?
>> > something else?
>> 
>> I thought of deriving from text-mode. I don't know much of change-log-
>> mode besides what it says in the mode title and now that I'm looking at
>> mode description it also sounds pretty vague. So… I could derive it
>> from change-log-mode if you think it's useful, but I'd rely on your
>> judgment here 😊
>
> change-log-mode is also a derivative of text-mode.  Its advantage is
> that it already provides font-lock for the style of log entries we
> use.

A thing that a git commit mode ought to do, however, is set fill-column
to 72, highlight any content on line 2 as erroneous, and limit the first
line to 50 characters.  This is conventional in Git:
https://git-scm.com/docs/git-commit#_discussion
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project.html#_commit_guidelines

Naturally, all of this ought to be configurable, but these are important
features and sane defaults, and are one of the primary reasons why I
initially installed magit (though, I now use it for general Git
interaction while editing).

As far as I know, some of these guidelines conflict with changelog
guidelines.
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 251 bytes --]