From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Sat, 04 Jan 2025 09:52:00 +0000 Message-ID: <875xmu9a9r.fsf@zephyr.silentflame.com> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86r05lht77.fsf@gnu.org> <875xmwykuk.fsf@aarsen.me> <87ed1j8vc2.fsf@zephyr.silentflame.com> <86o70nf3pp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: stefankangas@gmail.com, arsen@aarsen.me, Hi-Angel@yandex.ru, emacs-devel@gnu.org, jporterbugs@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 04 10:53:07 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU0qA-0000b6-9H for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jan 2025 10:53:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU0pP-0003r6-O3; Sat, 04 Jan 2025 04:52:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU0pO-0003qy-88 for emacs-devel@gnu.org; Sat, 04 Jan 2025 04:52:18 -0500 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU0pM-0007jw-MT for emacs-devel@gnu.org; Sat, 04 Jan 2025 04:52:18 -0500 DKIM-Signature: a=rsa-sha256; b=u6rfMX6YqpZYv63EeAioRC4Dmon13i4H1DrgyTk9YQjz3ANpJDx4oNQF1NeIbSX+XOZ6nGUkW1IPl6NrG9NPjIx28CZO2e7hwudIJCSoGO0H4QROG+jvi3IJNaMcztSsJBLFYwHH4R9TCOzCSTovu9iQXLzd5v7FZxhmUbh2lLl3mXzkmy0uw0mt0fwY26dON213yl2nyjyi3pgB520PygFnQMu1mGHXpmJzsAKX9azeA3sde+kSc7AjWa1murBI/RnxpZ9pBK7wcb3r2SynDt6vWpGsJKRn7R7hwdZi4N5/JMu0QzPHWEi6QyOpUUMHhaNTwQKTFhgN0tkgFecI1Q==; s=purelymail3; d=spwhitton.name; v=1; bh=A5yNeNIoN0lTYilR8XJpcs8PStOoddLO0EMBr4Fxx/U=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=HlVHA5xIbnPRrLSryVP/APVo5laZhWZ8Z6xU3SBQV0xSMLpicLRFbQAFiLDJuF7iSpnGqfcC/odmnVmSx/gk/lvACLSbx1pypllszh3Hq+HKIiHWVhFzgbJnIdIRVXdYPzMn/oxN75gZG7YsUIr46kQ0qoY+LiX2hoq6w9S3ckaffcamedUqYYy8herdD7dYECY1v7xKQh+sBNwxkqKxh/wvBQv7/k7Ws2AGIDRcLDphQ/IuPbSSxHWIYT1A2/kJ+mcpit7XKmhlPNME3S93N6VV6vsbSww+OT0jAP0U3g7OsabEdZgbZKqRM0e72HDHMqSpZINnuj3NKmNuZqih7w==; s=purelymail3; d=purelymail.com; v=1; bh=A5yNeNIoN0lTYilR8XJpcs8PStOoddLO0EMBr4Fxx/U=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -732359340; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 04 Jan 2025 09:52:01 +0000 (UTC) Original-Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 1114E94A6EB; Sat, 4 Jan 2025 09:52:00 +0000 (GMT) In-Reply-To: <86o70nf3pp.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jan 2025 09:17:06 +0200") Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327659 Archived-At: Hello, On Sat 04 Jan 2025 at 09:17am +02, Eli Zaretskii wrote: > vc-git-log-edit-mode kicks in only if one commits using VC commands. > It will not kick in if, for example, one commits from the shell prompt > with GIT_EDITOR set to invoke emacsclient. > > So there's still a place for a mode that is turned on when Emacs needs > to edit the files with special names used by Git for some of the > activities. Right, but ideally there could be some code reuse. >> (As the VC maintainer, I would have appreciated being CC'd on this >> thread at some point; glad I caught it anyway.) > > The thread was not about VC (still isn't, AFAICT), so it is not > surprising you were not CC'ed. It's closely enough related that I would have appreciated it. -- Sean Whitton