From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?U2HFoW8gxb1pdmFub3ZpxIc=?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix RefTeX to show table of contents for dtx files Date: Mon, 2 Jan 2017 16:41:24 +0100 Message-ID: <8755209c-85cf-570f-525b-69486a0fffaf@guest.arnes.si> References: <1de25256-ff37-a170-31aa-af2c4467953a@guest.arnes.si> <87k2adzm5a.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483372324 20693 195.159.176.226 (2 Jan 2017 15:52:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Jan 2017 15:52:04 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 02 16:52:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cO4tu-0004Xs-Qu for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 16:51:55 +0100 Original-Received: from localhost ([::1]:57488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO4ty-0005v6-Ur for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 10:51:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO4ge-0007Lq-SV for emacs-devel@gnu.org; Mon, 02 Jan 2017 10:38:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cO4gZ-0005oY-VV for emacs-devel@gnu.org; Mon, 02 Jan 2017 10:38:12 -0500 Original-Received: from avs4.arnes.si ([193.2.1.77]:54896) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cO4gZ-0005nW-Kd; Mon, 02 Jan 2017 10:38:07 -0500 Original-Received: from localhost (scanner2.arnes.si [193.2.0.11]) by avs4.arnes.si (Postfix) with ESMTP id 5FB6310B546; Mon, 2 Jan 2017 16:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=guest.arnes.si; h=content-transfer-encoding:content-type:content-type :in-reply-to:mime-version:user-agent:date:date:message-id:from :from:references:subject:subject:received:received:received :received; s=one; t=1483371474; x=1485963475; bh=6zMRxKWJKb4Jiso 8oZ3brDL37foIt0ceGp74MaXw/J8=; b=fQz0a8mC9PYotIQnasRBa/1JMi5uc4u 9quUFHN797JGyIoCjjc/S7Aq9yiM3F0rEf3CEuNshuEWxsY1P/q2Bgjz/v9NRt4s 8LY7z0KHrhPLQqTeWXf+aeAJICjCgTOlIkdSKUZQwHlrwJ4zFPUlLdehIGe6nCA6 liifz0q+Yl0E= Original-Received: from avs4.arnes.si ([193.2.1.77]) by localhost (scanner2.arnes.si [193.2.0.12]) (amavisd-new, port 10012) with ESMTP id c-cDamcoCNYf; Mon, 2 Jan 2017 16:37:54 +0100 (CET) Original-Received: from scanner2.arnes.si (scanner2.arnes.si [193.2.0.11]) by avs4.arnes.si (Postfix) with ESMTP id 4DEB522C09; Mon, 2 Jan 2017 16:37:54 +0100 (CET) X-Virus-Scanned: amavisd-new at guest.arnes.si Original-Received: from avs4.arnes.si ([193.2.1.77]) by scanner2.arnes.si (scanner2.arnes.si [193.2.0.12]) (amavisd-new, port 10010) with ESMTP id 4_f_F26nTWfi; Mon, 2 Jan 2017 16:37:53 +0100 (CET) Original-Received: from [192.168.64.102] (89-212-39-22.dynamic.t-2.net [89.212.39.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: szivan@mail.arnes.si) by avs4.arnes.si (Postfix) with ESMTPSA; Mon, 2 Jan 2017 16:37:53 +0100 (CET) In-Reply-To: <87k2adzm5a.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 193.2.1.77 X-Mailman-Approved-At: Mon, 02 Jan 2017 10:51:44 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211067 Archived-At: Hi Tassilo! Thanks for the prompt reply and commit! On 02. 01. 2017 13:22, Tassilo Horn wrote: > Sa=C5=A1o =C5=BDivanovi=C4=87 writes: > > Hi Sa=C5=A1o, > >> I've fixed a tiny bug in RefTeX: TOC was not shown for dtx files. > > Good catch, thanks! > > I've committed your patch with a slight modification. Instead of this > >> - (when toc-entry >> + (when (and toc-entry >> + (equal >> + (equal (char-after bound) ?%) >> + (string-suffix-p ".dtx" file) >> + )) > > I used > > (when (and toc-entry > (eq ;; Either both are t or both are nil. > (=3D (char-after bound) ?%) > (string-suffix-p ".dtx" file))) > > which looks a bit more clear to me. Fine with me. You see that my lisp is pretty rudimentary ... > > I've seen that this is your first patch to Emacs, and given that it's > less than 15 lines of code, I can commit it for you as-is. However, if > you plan to contribute more in the future, a copyright assignment will > be due. Gladly. Best, Sa=C5=A1o > > Bye, > Tassilo >