From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Changes to emacs/lisp/progmodes/grep.el Date: Fri, 02 Jul 2004 11:48:48 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <874qoq3i95.fsf@mail.jurta.org> References: <87isdgnzzi.fsf@mail.jurta.org> <20040625220304.0f1fd05a@pfdabpc.inhouse.start.de> <20040627123340.5d3354cd@pfdabpc.inhouse.start.de> <20040628104013.5b4eb37e@pfdabpc.inhouse.start.de> <7494-Mon28Jun2004200058+0300-eliz@gnu.org> <20040628232216.5be7f8dd@pfdabpc.inhouse.start.de> <5567-Tue29Jun2004071049+0300-eliz@gnu.org> <20040629220851.07104e4c@pfdabpc.inhouse.start.de> <87oen1k4yc.fsf@mail.jurta.org> <20040702235848.255ecbbe@pfdabpc.inhouse.start.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1088758394 359 80.91.224.253 (2 Jul 2004 08:53:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Jul 2004 08:53:14 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jul 02 10:53:04 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgJn6-0001lV-00 for ; Fri, 02 Jul 2004 10:53:04 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgJn6-0002Os-00 for ; Fri, 02 Jul 2004 10:53:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgJot-0004Qb-QO for emacs-devel@quimby.gnus.org; Fri, 02 Jul 2004 04:54:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BgJoe-0004QV-DJ for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:54:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BgJob-0004QI-5u for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:54:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgJoa-0004QF-VB for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:54:37 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BgJmI-0004x2-PB for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:52:15 -0400 Original-Received: from mail.jurta.org (80-235-32-26-dsl.mus.estpak.ee [80.235.32.26]) by spoon.dreamhost.com (Postfix) with ESMTP id AA24D13D814; Fri, 2 Jul 2004 01:52:11 -0700 (PDT) Original-To: Daniel Pfeiffer In-Reply-To: <20040702235848.255ecbbe@pfdabpc.inhouse.start.de> (Daniel Pfeiffer's message of "Fri, 2 Jul 2004 23:58:48 +0200") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25385 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25385 dapfy@t-online.de (Daniel Pfeiffer) writes: > Juri Linkov skribis: >> Currently I set `compilation-error-screen-columns' to nil in >> `grep-regexp-alist', but perhaps I should use `grep-error-screen-columns'? > > Ah ha! Grep inherits from compilation, so all the like-named variables get > passed through. As for your setting this on every match, I don't see the > point, not even setting this once. This is an option, which means that people > could set it to match the understanding of whatever external prog they use. If grep output contains at least one escape sequence used to surround the matching string, `compilation-error-screen-columns' should be set to nil, because the rule in `grep-regexp-alist' calculates the column positions of matches by subtracting the position of the first character after the file name and line number from the position of the first escape sequence, so these calculations are based on character positions, not on screen columns. This means that to find correct columns in the source buffers compilation-error-screen-columns should be nil to interpret calculated column numbers as characters. >> + (4 (list 'face nil 'invisible t 'intangible t)) >> + (5 (list 'face compilation-column-face)) >> + (6 (list 'face nil 'invisible t 'intangible t)) > > I've simplified these a little and made the face customizable, defaulting to > isearch's. isearch-lazy-highlight-face makes more sense since it is already used to highlight multiple matches in isearch mode which will be similar to matches in the grep buffer. >> diff -u -r1.322 compile.el >> --- lisp/progmodes/compile.el 18 Jun 2004 23:00:46 -0000 1.322 >> +++ lisp/progmodes/compile.el 30 Jun 2004 03:35:13 -0000 > >> + (overlay-put compilation-highlight-overlay 'face next-error-face)) > > This variable is undefined. Sorry, that face is from another opera :-) I posted only the relevant part of a whole patch which uses a new face `next-error-face' and a new option `next-error-highlight' whose another part I already posted earlier. -- Juri Linkov http://www.jurta.org/emacs/