From: Chong Yidong <cyd@stupidchicken.com>
Cc: Nick Roberts <nickrob@snap.net.nz>,
Romain Francoise <romain@orebokech.com>,
emacs-devel@gnu.org
Subject: Re: C-g crash redux
Date: Fri, 04 Aug 2006 12:03:07 -0400 [thread overview]
Message-ID: <874pwsebes.fsf@stupidchicken.com> (raw)
In-Reply-To: <877j1owmhx.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 04 Aug 2006 11:26:18 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> Another approach, which may be less risky, is to protect the portions
> of code in read_char where getcjmp is active. We should then be able
> to safely use unwind protects inside wait_reading_process_output.
The previous code suggestion I gave was not well thought out. The
correct way to implement this is as follows. I've checked that with
this change, the addition of wait_reading_process_output_unwind does
not cause a crash when C-g is done during sit-for.
Do you think this is the right approach?
*** emacs/src/keyboard.c.~1.862.~ 2006-08-01 11:00:25.000000000 -0400
--- emacs/src/keyboard.c 2006-08-04 12:00:29.000000000 -0400
***************
*** 2413,2418 ****
--- 2413,2419 ----
volatile int reread;
struct gcpro gcpro1, gcpro2;
int polling_stopped_here = 0;
+ int jmpcount;
also_record = Qnil;
***************
*** 2629,2639 ****
--- 2630,2642 ----
around any call to sit_for or kbd_buffer_get_event;
it *must not* be in effect when we call redisplay. */
+ jmpcount = SPECPDL_INDEX ();
if (_setjmp (local_getcjmp))
{
/* We must have saved the outer value of getcjmp here,
so restore it now. */
restore_getcjmp (save_jump);
+ unbind_to (jmpcount, Qnil);
XSETINT (c, quit_char);
internal_last_event_frame = selected_frame;
Vlast_event_frame = internal_last_event_frame;
next prev parent reply other threads:[~2006-08-04 16:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 20:50 C-g crash redux Romain Francoise
2006-08-02 22:07 ` Nick Roberts
2006-08-02 23:21 ` Kim F. Storm
2006-08-03 2:40 ` Nick Roberts
2006-08-03 15:13 ` Chong Yidong
2006-08-03 22:29 ` Kim F. Storm
2006-08-04 0:32 ` Chong Yidong
2006-08-04 1:49 ` Nick Roberts
2006-08-04 11:12 ` Kim F. Storm
2006-08-04 15:26 ` Chong Yidong
2006-08-04 16:03 ` Chong Yidong [this message]
2006-08-04 20:59 ` Richard Stallman
2006-08-04 22:07 ` Nick Roberts
2006-08-04 23:35 ` Kim F. Storm
2006-08-05 5:45 ` David Kastrup
2006-08-06 18:28 ` Richard Stallman
2006-08-06 20:58 ` Nick Roberts
2006-08-04 0:59 ` Nick Roberts
2006-08-03 4:16 ` Chong Yidong
2006-08-03 5:40 ` Nick Roberts
2006-08-03 7:17 ` Romain Francoise
2006-08-03 7:35 ` Stefan Monnier
2006-08-03 19:15 ` Richard Stallman
2006-08-03 19:14 ` Richard Stallman
2006-08-03 15:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874pwsebes.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.