From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Minibuffer default values list Date: Mon, 12 Nov 2007 01:45:14 +0200 Organization: JURTA Message-ID: <874pfsuzf9.fsf@jurta.org> References: <87zlycuhrd.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194825026 27704 80.91.229.12 (11 Nov 2007 23:50:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Nov 2007 23:50:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 12 00:50:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IrMZP-0006NT-7Z for ged-emacs-devel@m.gmane.org; Mon, 12 Nov 2007 00:50:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrMZD-0008UE-BO for ged-emacs-devel@m.gmane.org; Sun, 11 Nov 2007 18:50:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrMYd-0008HG-7z for emacs-devel@gnu.org; Sun, 11 Nov 2007 18:49:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrMYc-0008Gm-2Z for emacs-devel@gnu.org; Sun, 11 Nov 2007 18:49:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrMYb-0008Gh-V8 for emacs-devel@gnu.org; Sun, 11 Nov 2007 18:49:37 -0500 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IrMYb-0004Vj-CM for emacs-devel@gnu.org; Sun, 11 Nov 2007 18:49:37 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1IrMYZ-0003UX-CB for emacs-devel@gnu.org; Mon, 12 Nov 2007 01:49:35 +0200 In-Reply-To: <87zlycuhrd.fsf@jurta.org> (Juri Linkov's message of "Mon, 22 Oct 2007 03:22:15 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: 9596209fecb99bc4db4bd854cc333b75 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1761 [Nov 09 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 19 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82989 Archived-At: I remember there were discussions what the default value is better to use in `occur'. Now there is no need to select only one default value. The patch below adds a list of default values to `keep-lines', `flush-lines', `how-many' and `occur': Index: lisp/replace.el =================================================================== RCS file: /sources/emacs/emacs/lisp/replace.el,v retrieving revision 1.260 diff -c -r1.260 replace.el *** lisp/replace.el 10 Nov 2007 21:48:46 -0000 1.260 --- lisp/replace.el 11 Nov 2007 23:45:09 -0000 *************** *** 533,540 **** "Read arguments for `keep-lines' and friends. Prompt for a regexp with PROMPT. Value is a list, (REGEXP)." ! (list (read-from-minibuffer prompt nil nil nil ! 'regexp-history nil t) nil nil t)) (defun keep-lines (regexp &optional rstart rend interactive) --- 533,550 ---- "Read arguments for `keep-lines' and friends. Prompt for a regexp with PROMPT. Value is a list, (REGEXP)." ! (list (read-from-minibuffer ! prompt nil nil nil 'regexp-history ! (delq nil (list ! (regexp-quote ! (funcall (or find-tag-default-function ! (get major-mode 'find-tag-default-function) ! 'find-tag-default))) ! (car regexp-search-ring) ! (regexp-quote (car search-ring)) ! (car (symbol-value ! query-replace-from-history-variable)))) ! t) nil nil t)) (defun keep-lines (regexp &optional rstart rend interactive) *************** *** 938,958 **** (nreverse result)))) (defun occur-read-primary-args () ! (list (let* ((default (car regexp-history)) (input (read-from-minibuffer ! (if default ! (format "List lines matching regexp (default %s): " ! (query-replace-descr default)) ! "List lines matching regexp: ") ! nil ! nil ! nil ! 'regexp-history ! default))) ! (if (equal input "") ! default ! input)) (when current-prefix-arg (prefix-numeric-value current-prefix-arg)))) --- 948,972 ---- (nreverse result)))) (defun occur-read-primary-args () ! (list (let* ((default ! (delq nil (list ! (and transient-mark-mode mark-active ! (regexp-quote ! (buffer-substring-no-properties ! (region-beginning) (region-end)))) ! (regexp-quote ! (funcall (or find-tag-default-function ! (get major-mode 'find-tag-default-function) ! 'find-tag-default))) ! (car regexp-search-ring) ! (regexp-quote (car search-ring)) ! (car (symbol-value ! query-replace-from-history-variable))))) (input (read-from-minibuffer ! "List lines matching regexp: " ! nil nil nil 'regexp-history default))) ! input) (when current-prefix-arg (prefix-numeric-value current-prefix-arg)))) -- Juri Linkov http://www.jurta.org/emacs/