From: Miles Bader <miles@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
rms@gnu.org, emacs-devel@gnu.org
Subject: Re: C-u prefix behavior of TAB broken
Date: Sat, 22 Dec 2007 22:48:23 +0900 [thread overview]
Message-ID: <874peac02g.fsf@catnip.gol.com> (raw)
In-Reply-To: <476CD8CF.4060108@gmx.at> (martin rudalics's message of "Sat, 22 Dec 2007 10:28:47 +0100")
martin rudalics <rudalics@gmx.at> writes:
> For the case a prefix argument is given and the region is not active, we
> could try to set the region around the smallest containing form and call
> `indent-region' on that. But that would be a different feature.
Can't indent-for-tab-command simply, if there's a prefix argument given,
rigidly indent the following sexp by the change in indentation? That
doesn't seem hard at all, and matches the behavior I remember (perhaps
there are corner cases where it would differ, but I don't think I know
about them...).
For instance, the following isn't the most elegant code, but it seems to
do the right thing:
--- orig/lisp/indent.el
+++ mod/lisp/indent.el
@@ -99,13 +99,26 @@
(or (> (current-column) (current-indentation))
(eq this-command last-command))))
(insert-tab arg))
- ;; Those functions are meant specifically for tabbing and not for
- ;; indenting, so we can't pass them to indent-according-to-mode.
- ((memq indent-line-function '(indent-relative indent-relative-maybe))
- (funcall indent-line-function))
- ;; Indent the line.
(t
- (indent-according-to-mode))))
+ (let ((end-marker (and arg (save-excursion (forward-sexp) (point-marker))))
+ (old-indent (current-indentation)))
+
+ ;; Those functions are meant specifically for tabbing and not for
+ ;; indenting, so we can't pass them to indent-according-to-mode.
+ (if (memq indent-line-function '(indent-relative indent-relative-maybe))
+ (funcall indent-line-function)
+ ;; Indent the line.
+ (indent-according-to-mode))
+
+ ;; If a prefix argument was given, rigidly indent the following
+ ;; sexp to match the change in the current line's indentation.
+ ;;
+ (when arg
+ (let ((indentation-change (- (current-indentation) old-indent)))
+ (save-excursion
+ (forward-line 1)
+ (when (< (point) end-marker)
+ (indent-rigidly (point) end-marker indentation-change)))))))))
(defun insert-tab (&optional arg)
(let ((count (prefix-numeric-value arg)))
-Miles
--
"An atheist doesn't have to be someone who thinks he has a proof that there
can't be a god. He only has to be someone who believes that the evidence
on the God question is at a similar level to the evidence on the werewolf
question." [John McCarthy]
next prev parent reply other threads:[~2007-12-22 13:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 22:07 C-u prefix behavior of TAB broken Miles Bader
2007-12-17 12:48 ` martin rudalics
2007-12-17 14:27 ` Miles Bader
2007-12-17 19:03 ` martin rudalics
2007-12-21 0:20 ` Stefan Monnier
2007-12-21 19:49 ` Richard Stallman
2007-12-22 0:11 ` Miles Bader
2007-12-22 9:28 ` martin rudalics
2007-12-22 13:48 ` Miles Bader [this message]
2007-12-22 17:41 ` martin rudalics
2007-12-22 19:52 ` Miles Bader
2007-12-22 22:35 ` martin rudalics
2007-12-22 22:59 ` Miles Bader
2008-02-24 19:05 ` Juri Linkov
2008-02-24 19:26 ` Miles Bader
2008-02-24 19:40 ` Juri Linkov
2008-02-25 2:56 ` Miles Bader
2007-12-23 0:55 ` Stefan Monnier
2007-12-23 1:39 ` Miles Bader
2007-12-23 21:49 ` Stefan Monnier
2007-12-22 21:08 ` Richard Stallman
2007-12-22 22:08 ` martin rudalics
2007-12-23 21:11 ` Richard Stallman
2007-12-23 21:44 ` martin rudalics
2007-12-24 21:55 ` Richard Stallman
2007-12-24 22:33 ` martin rudalics
2007-12-26 5:29 ` Richard Stallman
2007-12-26 13:49 ` Vinicius Jose Latorre
2007-12-26 21:26 ` Richard Stallman
2007-12-27 20:19 ` Juri Linkov
2007-12-28 13:55 ` Richard Stallman
2007-12-28 13:55 ` Richard Stallman
2008-01-03 21:52 ` Juri Linkov
2008-01-03 23:50 ` Miles Bader
2007-12-23 0:51 ` Stefan Monnier
2007-12-23 9:13 ` martin rudalics
2007-12-26 3:00 ` Miles Bader
2007-12-18 2:24 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874peac02g.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.