[mouse-1 in Customize should respect mouse-1-click-follows-link]

[mouse-1 in Customize should respect mouse-1-click-follows-link]

[Richard Stallman]

What do people think of this issue?

------- Start of forwarded message -------
From: "Drew Adams" <drew.adams@oracle.com>
To: "Bug-Gnu-Emacs" <bug-gnu-emacs@gnu.org>
Date: Wed, 26 Dec 2007 13:28:30 -0800
Message-ID: <DHEEKFAFJEFOJHLCFPFDCECBCDAA.drew.adams@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: mouse-1 in Customize should respect mouse-1-click-follows-link

Click mouse-1 on a link in a Customize buffer that is a link to
another option name or similar. That is, on text between `' that is
highlighted with mouseover (`mouse-face').  The link is followed.

The link should not be followed by `mouse-1' if
`mouse-1-click-follows-link' is nil.  In that case, only clicking
`mouse-2' should follow the link.


In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'
------- End of forwarded message -------

RE: [mouse-1 in Customize should respect mouse-1-click-follows-link]

[Drew Adams]

Resending.

These are links. They should be controlled by `mouse-1-click-follows-link'.


> From: Richard Stallman Sent: Friday, December 28, 2007 2:10 PM
> 
> What do people think of this issue?
>
>
> ------- Start of forwarded message -------
> From: "Drew Adams" <drew.adams@oracle.com>
> To: "Bug-Gnu-Emacs" <bug-gnu-emacs@gnu.org>
> Date: Wed, 26 Dec 2007 13:28:30 -0800
> Message-ID: <DHEEKFAFJEFOJHLCFPFDCECBCDAA.drew.adams@oracle.com>
> MIME-Version: 1.0
> Content-Type: text/plain;
> 	charset="iso-8859-1"
> Subject: mouse-1 in Customize should respect 
> mouse-1-click-follows-link
> 
> Click mouse-1 on a link in a Customize buffer that is a link to
> another option name or similar. That is, on text between `' that is
> highlighted with mouseover (`mouse-face').  The link is followed.
> 
> The link should not be followed by `mouse-1' if
> `mouse-1-click-follows-link' is nil.  In that case, only clicking
> `mouse-2' should follow the link.
> 
> 
> In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
>  of 2007-06-02 on RELEASE
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --cflags 
> -Ic:/gnuwin32/include'

Re: [mouse-1 in Customize should respect mouse-1-click-follows-link]

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

"Drew Adams" <drew.adams@oracle.com> writes:

> These are links. They should be controlled by
> `mouse-1-click-follows-link'.

They behave like links but they are really widget buttons.
I doubt there is a simple fix for this.

,----[ `C-u C-x =' on such a "link" ]
| This is an active area of a documentation-link (widget)Top.
| 
| There are 2 overlays here:
|  From 3145 to 3885
|   evaporate            t
|   face                 custom-documentation
|   widget-doc           documentation-string (widget)Top
|  From 3372 to 3384
|   button               documentation-link (widget)Top
|   evaporate            t
|   face                 custom-documentation
|   follow-link          mouse-face
|   help-echo            "Describe this symbol"
|   keymap               nil
|   mouse-face           (highlight)
|   pointer              hand
`----

Anyway, the `follow-link' property was set to "^m".
The following patch corrects this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: wid-edit.el.patch --]
[-- Type: text/x-diff, Size: 510 bytes --]

Index: wid-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v
retrieving revision 1.188
diff -u -r1.188 wid-edit.el
--- wid-edit.el	9 Feb 2008 22:48:05 -0000	1.188
+++ wid-edit.el	12 Mar 2008 10:57:02 -0000
@@ -1773,7 +1773,7 @@
   "An embedded link."
   :button-prefix 'widget-link-prefix
   :button-suffix 'widget-link-suffix
-  :follow-link "\C-m"
+  :follow-link 'mouse-face
   :help-echo "Follow the link."
   :format "%[%t%]")
 

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

Re: [mouse-1 in Customize should respect mouse-1-click-follows-link]

[Bastien]

> Index: wid-edit.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v
> retrieving revision 1.188
> diff -u -r1.188 wid-edit.el
> --- wid-edit.el	9 Feb 2008 22:48:05 -0000	1.188
> +++ wid-edit.el	12 Mar 2008 10:57:02 -0000
> @@ -1773,7 +1773,7 @@
>    "An embedded link."
>    :button-prefix 'widget-link-prefix
>    :button-suffix 'widget-link-suffix
> -  :follow-link "\C-m"
> +  :follow-link 'mouse-face
>    :help-echo "Follow the link."
>    :format "%[%t%]")

FYI I applied this patch.

-- 
Bastien