dired-jump keybinding and autoload

[Stephen Berman <Stephen.Berman@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Start Emacs with -Q, type C-x C-j, Emacs beeps and says "C-x C-j is
undefined".  Now type `M-x dired-jump' and you get a Dired buffer of the
default directory.  Type q to bury it, and now typing C-x C-j works and
brings up the default directory again.  The reason for this behavior is
that the command dired-jump from dired-x.el is autoloaded, but its
default global keybinding, C-x C-j, is not.  Since this keybinding is
conditioned on the value of the defcustom dired-bind-jump, it is not
possible to put the keybinding on an autoload cookie, as is done
e.g. with C-x d in dired.el.  But users can always change or eliminate
the keybinding anyway, so dired-bind-jump isn't really a very
interesting defcustom.  So, since the default value of dired-bind-jump
is t, I suggest eliminating dired-bind-jump and the condition on the
keybinding, and autoloading the latter.  Ditto for the keybinding of
dired-jump-other-window, and also autoload this command.

Steve Berman


2008-05-08  Stephen Berman  <Stephen.Berman@gmx.net>

	* dired-x.el (dired-bind-jump): Eliminate.
	Add key bindings for `dired-jump' and `dired-jump-other-window' as
	autoload cookies.
	(dired-jump-other-window): Add autoload cookie.


[-- Attachment #2: dired-x.el patch --]
[-- Type: text/plain, Size: 2128 bytes --]

*** /Users/steve/cvsroot/emacs/lisp/dired-x.el.~1.91.~	2008-05-06 17:54:02.000000000 +0200
--- /Users/steve/cvsroot/emacs/lisp/dired-x.el	2008-05-08 14:24:58.000000000 +0200
***************
*** 59,65 ****
  ;;
  ;;      dired-bind-vm
  ;;      dired-vm-read-only-folders
- ;;      dired-bind-jump
  ;;      dired-bind-info
  ;;      dired-bind-man
  ;;      dired-x-hands-off-my-keys
--- 59,64 ----
***************
*** 128,138 ****
    :type 'boolean
    :group 'dired-keys)
  
- (defcustom dired-bind-jump t
-   "*Non-nil means bind `dired-jump' to C-x C-j, otherwise do not."
-   :type 'boolean
-   :group 'dired-keys)
- 
  (defcustom dired-bind-man t
    "*Non-nil means bind `dired-man' to \"N\" in dired-mode, otherwise do not."
    :type 'boolean
--- 127,132 ----
***************
*** 324,335 ****
          :help "Enable or disable omitting \"uninteresting\" files")
        'dashes)))
  
- ;;; GLOBAL BINDING.
- (if dired-bind-jump
-     (progn
-       (define-key global-map "\C-x\C-j" 'dired-jump)
-       (define-key global-map "\C-x4\C-j" 'dired-jump-other-window)))
- 
  \f
  ;;; Install into appropriate hooks.
  
--- 318,323 ----
***************
*** 351,357 ****
  For more features, see variables
  
    `dired-bind-vm'
-   `dired-bind-jump'
    `dired-bind-info'
    `dired-bind-man'
    `dired-vm-read-only-folders'
--- 339,344 ----
***************
*** 496,501 ****
--- 483,489 ----
  \f
  ;;; JUMP.
  
+ ;;;###autoload (define-key ctl-x-map "\C-j" 'dired-jump)
  ;;;###autoload
  (defun dired-jump (&optional other-window)
    "Jump to dired buffer corresponding to current buffer.
***************
*** 530,535 ****
--- 518,525 ----
  		    (dired-omit-mode)
  		    (dired-goto-file file))))))))
  
+ ;;;###autoload (define-key ctl-x-4-map "\C-j" 'dired-jump-other-window)
+ ;;;###autoload
  (defun dired-jump-other-window ()
    "Like \\[dired-jump] (`dired-jump') but in other window."
    (interactive)
***************
*** 1751,1757 ****
    (list
     'dired-bind-vm
     'dired-vm-read-only-folders
-    'dired-bind-jump
     'dired-bind-info
     'dired-bind-man
     'dired-find-subdir
--- 1741,1746 ----