From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#410: 23.0.60; display-buffer regression Date: Sun, 15 Jun 2008 00:34:47 +0200 Message-ID: <874p7vfxx4.fsf@escher.local.home> References: <873anhkn4m.fsf@escher.local.home> <4853920E.9020106@gmx.at> Reply-To: Stephen Berman , 410@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213483644 7674 80.91.229.12 (14 Jun 2008 22:47:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2008 22:47:24 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 15 00:48:08 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7eXX-0001cL-LO for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jun 2008 00:48:07 +0200 Original-Received: from localhost ([127.0.0.1]:44835 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7eWj-0005Xp-FX for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2008 18:47:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7eWe-0005WQ-7L for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:47:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7eWc-0005Uw-HS for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:47:11 -0400 Original-Received: from [199.232.76.173] (port=52445 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7eWc-0005Us-AZ for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:47:10 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34961) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7eWb-0001aN-TN for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:47:10 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EMl71i014379; Sat, 14 Jun 2008 15:47:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m5EMj3Ls013248; Sat, 14 Jun 2008 15:45:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Stephen Berman Original-Sender: news Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 14 Jun 2008 22:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 410 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121348292312003 (code B ref -1); Sat, 14 Jun 2008 22:45:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jun 2008 22:35:23 +0000 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5EMZHrs011997 for ; Sat, 14 Jun 2008 15:35:19 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7eL7-0001IJ-5q for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:35:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7eL5-0001Hv-W1 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:35:16 -0400 Original-Received: from [199.232.76.173] (port=38398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7eL5-0001Hm-K6 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:35:15 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:51012 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7eL5-0000XI-9G for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 18:35:15 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K7eKy-0000fW-7b for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2008 22:35:08 +0000 Original-Received: from i5387e512.versanet.de ([83.135.229.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Jun 2008 22:35:08 +0000 Original-Received: from stephen.berman by i5387e512.versanet.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Jun 2008 22:35:08 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 45 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: i5387e512.versanet.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Sat, 14 Jun 2008 18:47:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18402 gmane.emacs.pretest.bugs:22633 Archived-At: On Sat, 14 Jun 2008 11:40:30 +0200 martin rudalics wrote: >> The recent reimplementation of display-buffer in lisp resulted in the >> following changed behavior, which I consider a regression: >> >> 1. emacs -Q >> >> 2. M-x calendar >> ==> The window is vertically split, the *scratch* buffer above and >> the Calendar buffer is below in a smaller window sized to fit. >> >> 3. M-: (pop-to-buffer (get-buffer "*Messages*")) >> ==> Now the *Messages* buffer is above and the Calendar buffer is >> still below, but the windows are evenly split, i.e. the Calendar >> window is no longer sized to fit but is too big. Prior to the >> reimplementation of display-buffer doing this step did not change the >> height of the Calendar window. >> >> The behavior in step 3 results from the invocation of >> window--even-window-heights in the last clause of the cond in >> display-buffer, which happens because the *Messages* buffer exits but is >> not displayed. If the sexp in step 3 contained *scratch* instead of >> *Messages*, the height of the Calendar window would not have changed. > > Thanks for noticing this. > >> Looking at the pre-reimplementation source of Fdisplay_buffer, it looks >> like the window heights should get evened out just as in the lisp >> reimplementation; nevertheless, this is not what happens in the above >> recipe with the older code. > > It's because in the Elisp code I evened window heights whenever they > were not equal. The original code evened heights only when the height > of the window to display BUFFER-OR-NAME was less than that of the > selected window. Thanks for the explication, I didn't grasp that in my cursory perusal. > I've tried to restore the original behavior. Please > try again. Your patch makes display-buffer work as it previously did in cases like the above; thanks. Steve Berman