From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Phil Hagelberg Newsgroups: gmane.emacs.devel Subject: Re: vc-register complains if a file is already registered in a git repository Date: Tue, 28 Oct 2008 15:24:21 -0700 Message-ID: <874p2w73ze.fsf@hagelb.org> References: <87prlvm2ms.fsf@hagelb.org> <873aipmvt6.fsf@hagelb.org> <87od147hzj.fsf@hagelb.org> <87ej207fc7.fsf@hagelb.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225232679 29236 80.91.229.12 (28 Oct 2008 22:24:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Oct 2008 22:24:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 28 23:25:40 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kux0N-00054U-Hp for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2008 23:25:39 +0100 Original-Received: from localhost ([127.0.0.1]:59276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuwzH-0003Vy-1U for ged-emacs-devel@m.gmane.org; Tue, 28 Oct 2008 18:24:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KuwzE-0003Vb-4t for emacs-devel@gnu.org; Tue, 28 Oct 2008 18:24:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KuwzC-0003Tr-KZ for emacs-devel@gnu.org; Tue, 28 Oct 2008 18:24:27 -0400 Original-Received: from [199.232.76.173] (port=52338 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KuwzC-0003Tk-Fc for emacs-devel@gnu.org; Tue, 28 Oct 2008 18:24:26 -0400 Original-Received: from sd-green-bigip-207.dreamhost.com ([208.97.132.207]:42806 helo=spunkymail-a20.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KuwzC-0000QD-Ph for emacs-devel@gnu.org; Tue, 28 Oct 2008 18:24:27 -0400 Original-Received: from dynabook (unknown [64.81.164.191]) by spunkymail-a20.g.dreamhost.com (Postfix) with ESMTP id 5C1BBE250F; Tue, 28 Oct 2008 15:24:22 -0700 (PDT) In-Reply-To: <87ej207fc7.fsf@hagelb.org> (Phil Hagelberg's message of "Tue, 28 Oct 2008 11:19:04 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105115 Archived-At: Phil Hagelberg writes: > Phil Hagelberg writes: > >> I've added the vc-git-register-changes command to vc-git-extra-menu-map >> and will start work on creating extra-keys functionality that works like >> extra-menu. > > OK, here's the cumulative patch for both features. Disregard that patch; it runs the append-extra-keys invocation at load time, not when the vc-prefix-map is invoked. It's really unclear due to the way prefix maps work how you can append something to the map when it is invoked. For the menu maps it looks like there are filter functions that are meant to do that, but it I can't find any way to do this for prefix keymaps. I suspect it would be much more straightforward if vc-register-changes were simply a top-level vc command that most backends simply didn't implement. -Phil