From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: improving network utility calls in lisp/net/net-utils.el Date: Sun, 02 Aug 2009 18:34:04 -0400 Message-ID: <874ospsv4z.fsf@cyd.mit.edu> References: <87ljq8lk9u.fsf@rabkins.net> <87y6u8k3bo.fsf@rabkins.net> <49DF7679.20700@harpegolden.net> <87eiw0v1eq.fsf@rabkins.net> <874owvk25g.fsf@rabkins.net> <83ab6n36mm.fsf@gnu.org> <87iqlbim6k.fsf@rabkins.net> <87tz1cpfqm.fsf@rabkins.net> <87my6im388.fsf@rabkins.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1249252418 24908 80.91.229.12 (2 Aug 2009 22:33:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Aug 2009 22:33:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Yoni Rabkin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 03 00:33:31 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MXjcQ-000896-G6 for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2009 00:33:30 +0200 Original-Received: from localhost ([127.0.0.1]:55562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXjcP-0006Tq-PX for ged-emacs-devel@m.gmane.org; Sun, 02 Aug 2009 18:33:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXjcK-0006Tl-0t for emacs-devel@gnu.org; Sun, 02 Aug 2009 18:33:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXjcF-0006TV-O0 for emacs-devel@gnu.org; Sun, 02 Aug 2009 18:33:23 -0400 Original-Received: from [199.232.76.173] (port=42828 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXjcF-0006TS-J2 for emacs-devel@gnu.org; Sun, 02 Aug 2009 18:33:19 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:52064) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXjcF-0005v9-3p for emacs-devel@gnu.org; Sun, 02 Aug 2009 18:33:19 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 9FF5A57E275; Sun, 2 Aug 2009 18:34:04 -0400 (EDT) In-Reply-To: <87my6im388.fsf@rabkins.net> (Yoni Rabkin's message of "Sun, 02 Aug 2009 22:21:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113576 Archived-At: Yoni Rabkin writes: > Does anyone have time to install this? Terribly sorry for the delay, I haven't had time to review your patch till just now. With your change, the ifconfig, iwconfig, netstat, arp, and route commands are no longer autoloaded. Could you fix this? (And personally, I'd write out the function definitions manually instead of using the net-utils-defutil macro, because the macro probably confuses C-h f. It's not that much more work.) Also, please make net-utils-font-lock-keywords a defvar, not a defconst (make nslookup-font-lock-keywords a defvar too, while you're at it). Once you make these changes, just send me the revised patch with a ChangeLog entry, and I'll install it. Thanks for your patience.