PATCH term optional bold

PATCH term optional bold

[Ivan Kanis]

Hello,

This small patch make optional the usage of bold attribute in term. I
have signed the emacs paper for contributing code.

Kind regards,

Ivan Kanis http://kanis.fr

diff -r fbdd847e04eb lisp/misc/term.el
--- a/lisp/misc/term.el	Fri Sep 11 14:36:54 2009 +0200
+++ b/lisp/misc/term.el	Fri Sep 11 14:59:23 2009 +0200
@@ -476,11 +476,13 @@
 (defvar term-old-mode-line-format) ;; Saves old mode-line-format while paging.
 (defvar term-pager-old-local-map nil) ;; Saves old keymap while paging.
 (defvar term-pager-old-filter) ;; Saved process-filter while paging.
-
 (defcustom explicit-shell-file-name nil
   "If non-nil, is file name to use for explicitly requested inferior shell."
   :type '(choice (const nil) file)
   :group 'term)
+
+(defvar term-enable-bold t
+  "Set to nil to disable bold")
 
 (defvar term-prompt-regexp "^"
   "Regexp to recognize prompts in the inferior process.
@@ -3227,7 +3229,8 @@
 			(if (= term-ansi-current-bg-color 0)
 			    term-default-bg-color
 			  (elt ansi-term-color-vector term-ansi-current-bg-color))))
-	    (when term-ansi-current-bold
+	    (when (and term-ansi-current-bold
+	               term-enable-bold)
 	      (setq term-current-face
 		    (append '(:weight bold) term-current-face)))
 	    (when term-ansi-current-underline
@@ -3255,7 +3258,8 @@
 		      (if (= term-ansi-current-bg-color 0)
 			  term-default-bg-color
 			(elt ansi-term-color-vector term-ansi-current-bg-color))))
-	  (when term-ansi-current-bold
+	  (when (and term-ansi-current-bold
+	             term-enable-bold)
 	    (setq term-current-face
 		  (append '(:weight bold) term-current-face)))
 	  (when term-ansi-current-underline

Re: PATCH term optional bold

[Stefan Monnier]

> This small patch make optional the usage of bold attribute in term.

Could you give us some background explaining the motivation for this?

> +(defvar term-enable-bold t
> +  "Set to nil to disable bold")
[...]
> -	    (when term-ansi-current-bold
> +	    (when (and term-ansi-current-bold
> +	               term-enable-bold)
>  	      (setq term-current-face
>  		    (append '(:weight bold) term-current-face)))
[...]
> -	  (when term-ansi-current-bold
> +	  (when (and term-ansi-current-bold
> +	             term-enable-bold)
>  	    (setq term-current-face
>  		  (append '(:weight bold) term-current-face)))

I think it'd be even better to do something like

> +(defvar term-bold-attribute '(:weight bold)
> +  "Set to nil to disable bold")
[...]
>  	    (when term-ansi-current-bold
>  	      (setq term-current-face
> - 		    (append '(:weight bold) term-current-face)))
> + 		    (append term-bold-attribute term-current-face)))
[...]
> 	  (when term-ansi-current-bold
>  	    (setq term-current-face
> - 		    (append '(:weight bold) term-current-face)))
> + 		    (append term-bold-attribute term-current-face)))

WDYT?


        Stefan

Re: PATCH term optional bold

[Ivan Kanis]

Hi Stefan,

Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> This small patch make optional the usage of bold attribute in term.
> Could you give us some background explaining the motivation for this?

I can't stand bold font and try to disable it whenever I can. There is a
big misunderstanding about bold in terminal emulation. In a true dumb
terminal like a vt220 bold was a brighter color.

> I think it'd be even better to do something like
> [...your patch..]
>> 	  (when term-ansi-current-bold
>>  	    (setq term-current-face
>> - 		    (append '(:weight bold) term-current-face)))
>> + 		    (append term-bold-attribute term-current-face)))
>
> WDYT?

I think it's better it allows more customization, I have fixed up your
patch a little bit and tested. I use progn for the setq and update the
comment of the defvar.

--- a/lisp/misc/term.el Fri Sep 11 14:36:54 2009 +0200
+++ b/lisp/misc/term.el Sat Sep 12 09:29:30 2009 +0200
@@ -476,11 +476,16 @@
 (defvar term-old-mode-line-format) ;; Saves old mode-line-format while paging.
 (defvar term-pager-old-local-map nil) ;; Saves old keymap while paging.
 (defvar term-pager-old-filter) ;; Saved process-filter while paging.
 (defcustom explicit-shell-file-name nil
   "If non-nil, is file name to use for explicitly requested inferior shell."
   :type '(choice (const nil) file)
   :group 'term)
+
+(defvar term-enable-bold t
+  "Set to nil to disable bold")
+
+(defvar term-bold-attribute '(:weight bold)
+  "Set to '(:weight normal) to disable bold")
 
 (defvar term-prompt-regexp "^"
   "Regexp to recognize prompts in the inferior process.
@@ -3228,8 +3233,9 @@
                            term-default-bg-color
                          (elt ansi-term-color-vector term-ansi-current-bg-color
))))                                                                           
            (when term-ansi-current-bold
-             (setq term-current-face
-                   (append '(:weight bold) term-current-face)))
+             (setq term-current-face 
+                   (append '(:weight bold) term-current-face)
+                   (append term-bold-attribute term-current-face)))
            (when term-ansi-current-underline
              (setq term-current-face
                    (append '(:underline t) term-current-face))))
@@ -3257,7 +3263,9 @@
                        (elt ansi-term-color-vector term-ansi-current-bg-color))
))                                                                             
          (when term-ansi-current-bold
            (setq term-current-face
-                 (append '(:weight bold) term-current-face)))
+                  (progn
+                    (append '(:weight bold) term-current-face)
+                    (append '(:weight bold) term-current-face)))
          (when term-ansi-current-underline
            (setq term-current-face
                  (append '(:underline t) term-current-face))))))

Re: PATCH term optional bold

[Miles Bader]

Ivan Kanis <expire-by-2009-09-17@kanis.fr> writes:
> I think it's better it allows more customization, I have fixed up your
> patch a little bit and tested. I use progn for the setq and update the
> comment of the defvar.

Your patch seems to make no sense at all.

Just use Stefan's patch, and set `term-bold-attribute' to your liking.

-Miles

-- 
Friendship, n. A ship big enough to carry two in fair weather, but only one
in foul.

Re: PATCH term optional bold

[Ivan Kanis]

Miles Bader <miles@gnu.org> wrote:

> Ivan Kanis <expire-by-2009-09-17@kanis.fr> writes:
>> I think it's better it allows more customization, I have fixed up your
>> patch a little bit and tested. I use progn for the setq and update the
>> comment of the defvar.
>
> Your patch seems to make no sense at all.

Which bit didn't make sense to you? I forgot to remove term-enable-bold
that should go away.

Kind regards,
-- 
Ivan
Kanis http://kanis.fr

We look at the present through a rear-view mirror. We march backwards
into the future.
    -- Marshall McLuhan