all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Fix info display of images
Date: Mon, 07 Dec 2009 21:28:21 +0100	[thread overview]
Message-ID: <874oo2jzq2.fsf@lola.goethe.zz> (raw)
In-Reply-To: 87ljhey8gx.fsf@mail.jurta.org

Juri Linkov <juri@jurta.org> writes:

>> the info images in the Lilypond documentation have a rather messed-up
>> display.  That's more or less due to Emacs putting "invisible"
>> properties over image code indiscriminately.
>>
>> I find that the following does help.
>
> If you provided a test case, I would be able to confirm whether it
> works or not.

I can't easily provide a useful test case since that requires the
corresponding image files as well, and those are in one rather large
directory.

*I* can confirm that the patch works as intended.

> But now it seems strange to me that you fix this in
> `Info-hide-cookies-node' instead of `Info-display-images-node'.

The problem is that `Info-hide-cookies-node' rehides the images.  The
combination of invisible and display properties wreaks havoc on the
resulting display and cursor movement.  This gets even worse because the
images are also displayed using the "rear-nonsticky (display)" property,
which implies that all other properties (including invisible) become
rear-sticky.

So Info-hide-cookies-node should simply refrain from tampering with
cookies that have already been handled.

The extended test in my patch does that.

-- 
David Kastrup





  reply	other threads:[~2009-12-07 20:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05 23:48 Fix info display of images David Kastrup
2009-12-07 17:55 ` Juri Linkov
2009-12-07 20:28   ` David Kastrup [this message]
2009-12-13 11:09     ` David Kastrup
2009-12-13 18:31       ` Juri Linkov
2009-12-14  4:16         ` Chong Yidong
2009-12-14  5:14           ` Ediff-patch-file with wrong default buffer (was: Fix info display of images) Juri Linkov
2009-12-14  5:43             ` Michael Kifer
2009-12-14  5:47               ` Ediff-patch-file with wrong default buffer Juri Linkov
2009-12-14  6:15                 ` Michael Kifer
2009-12-14  6:54                   ` Juri Linkov
2010-02-02  0:31                     ` Juri Linkov
2010-02-02  2:34                       ` Stefan Monnier
2010-02-02 22:38                         ` Juri Linkov
2010-02-02  0:33                     ` Juri Linkov
2009-12-14  9:35                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874oo2jzq2.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.