From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Line height too small with Monaco font on Mac OS X Date: Mon, 08 Feb 2010 18:43:54 -0500 Message-ID: <874olrz41x.fsf@stupidchicken.com> References: <256A1330-5C0B-4F54-926E-83C95923067D@devrx.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1265672658 4291 80.91.229.12 (8 Feb 2010 23:44:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Feb 2010 23:44:18 +0000 (UTC) Cc: francis@devrx.org, 3975@debbugs.gnu.org, emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 09 00:44:16 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NedH5-0000CC-8F for ged-emacs-devel@m.gmane.org; Tue, 09 Feb 2010 00:44:15 +0100 Original-Received: from localhost ([127.0.0.1]:33141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NedH4-000690-Nq for ged-emacs-devel@m.gmane.org; Mon, 08 Feb 2010 18:44:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NedH0-00068B-67 for emacs-devel@gnu.org; Mon, 08 Feb 2010 18:44:10 -0500 Original-Received: from [199.232.76.173] (port=50696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NedGy-000671-RP for emacs-devel@gnu.org; Mon, 08 Feb 2010 18:44:08 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NedGx-0001d5-GW for emacs-devel@gnu.org; Mon, 08 Feb 2010 18:44:08 -0500 Original-Received: from pantheon-po25.its.yale.edu ([130.132.50.119]:48966) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NedGx-0001cz-6z for emacs-devel@gnu.org; Mon, 08 Feb 2010 18:44:07 -0500 Original-Received: from furry (bb116-15-9-83.singnet.com.sg [116.15.9.83]) (authenticated bits=0) by pantheon-po25.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o18Nhtbr016133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Feb 2010 18:43:57 -0500 Original-Received: by furry (Postfix, from userid 1000) id A9A7DC05D; Mon, 8 Feb 2010 18:43:54 -0500 (EST) In-Reply-To: (Leo's message of "Mon, 08 Feb 2010 20:16:36 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121031 Archived-At: Leo writes: > On 2010-02-08 11:10 +0000, Francis Devereux wrote: >> A few months ago I tried out Emacs 23.1 on Mac OS X, and found that >> the line height was too small when using the Monaco font (some >> characters are clipped at the bottom, including ()[]). I downloaded >> and compiled Emacs 23.1.92 today and found that it still has the same >> problem. >> >> Could someone have a look at the patch I added to >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3975 >> and apply it if it looks OK? > > No wonder I always feel a bit weird using monaco. I have moved to DejaVu > Sans Mono and it is looking better. > > Patch is attached to bug #3975. Maybe someone can review it? I've reviewed the patch, and it looks ok. I've checked it in, could you test it?