bookmark from gnus article wrong modification

bookmark from gnus article wrong modification

[Thierry Volpiatto]

Hi,
the last modification for compatibility with older emacs in gnus-sum.el
is wrong.
You should use the value of pos what is set to point IN THE ARTICLE
BUFFER.
If you use just (point) it will record the value of point in the summary
buffer what is wrong and not what we want:

,----
|       `(,subject
| 	,@(condition-case nil
| 	      (bookmark-make-record-default 'no-file 'no-context (point))
| 	    (wrong-number-of-arguments
| 	     (bookmark-make-record-default 'point-only)))
`----

See precedent patchs for example.

Also this change add tabs that also is wrong i think (you should
untabify).

This changes occur in:

,----
| changeset:   109420:8fa1cd12c77f
| user:        Katsumi Yamaoka <yamaoka@jpl.org>
| date:        Thu Jul 15 00:54:06 2010 +0000
| summary:     Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
`----


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: bookmark from gnus article wrong modification

[Karl Fogel]

On Fri, Jul 16, 2010 at 9:16 AM, Thierry Volpiatto
<thierry.volpiatto@gmail.com> wrote:
> Hi,
> the last modification for compatibility with older emacs in gnus-sum.el
> is wrong.
> You should use the value of pos what is set to point IN THE ARTICLE
> BUFFER.
> If you use just (point) it will record the value of point in the summary
> buffer what is wrong and not what we want:

Thanks, Thierry.  I'm on the road right now but will take care of this
once not traveling.  On my list!

-Karl

> ,----
> |       `(,subject
> |       ,@(condition-case nil
> |             (bookmark-make-record-default 'no-file 'no-context (point))
> |           (wrong-number-of-arguments
> |            (bookmark-make-record-default 'point-only)))
> `----
>
> See precedent patchs for example.
>
> Also this change add tabs that also is wrong i think (you should
> untabify).
>
> This changes occur in:
>
> ,----
> | changeset:   109420:8fa1cd12c77f
> | user:        Katsumi Yamaoka <yamaoka@jpl.org>
> | date:        Thu Jul 15 00:54:06 2010 +0000
> | summary:     Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
> `----
>
>
> --
> Thierry Volpiatto
> Get my Gnupg key:
> gpg --keyserver pgp.mit.edu --recv-keys 59F29997
>
>
>

Re: bookmark from gnus article wrong modification

[Katsumi Yamaoka]

Thierry Volpiatto wrote:
> the last modification for compatibility with older emacs in gnus-sum.el
> is wrong.

Oops, that's my fault.  Thanks for pointing it out.
Fixed in both the Gnus trunk and the Emacs trunk.

Regards,

Re: bookmark from gnus article wrong modification

[Thierry Volpiatto]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Thierry Volpiatto wrote:
>> the last modification for compatibility with older emacs in gnus-sum.el
>> is wrong.
>
> Oops, that's my fault.  Thanks for pointing it out.
> Fixed in both the Gnus trunk and the Emacs trunk.

Thanks.;-)

-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997