bug#7205: 24.0.50; Font customizations not being applied properly at startup

bug#7205: 24.0.50; Font customizations not being applied properly at startup

[Tim Van Holder]

This can't be reproduced with 'emacs -Q'.

I have custom-file customized as "~/.custom.el".
My .emacs has
  (setq custom-file "~/.custom.el")
  (load custom-file)
at the top to ensure that it gets loaded.

In current bzr (r101947) this is not loading all face customizations
anymore. Ediff faces in particular seem to be affected.
After startup, list-faces-display shows the diff-xxx faces as their
defaults, not the customized version.
Eval'ing the custom-set-faces in .custom.el does update the customized
colors, but values not explictly overridden remain (e.g. on diff-header,
my customized version has no background color set, but the default
background color is retained after the eval). Hitting [enter] in the
face list for these faces takes me to a customization buffer that
declares that the face is set as STANDARD. In fact, this seems to be the
case for all faces, even those that do get loaded "correctly".
So I tried (re)customizing a face (show-paren-match) and after saving
that, .custom.el lost all the previous face customizations, replacing
them with a single one:

  (custom-set-faces
   ;; custom-set-faces was added by Custom.
   ;; If you edit it by hand, you could mess it up, so be careful.
   ;; Your init file should contain only one such instance.
   ;; If there is more than one, they won't work right.
   '(show-paren-match
     ((t
       (:background "Navy" :foreground "Wheat" :weight bold)))))

In the original file, the entry was:

   '(show-paren-match
     ((((class color))
       (:bold t :foreground "Wheat" :background "Navy"))))

(both examples reformatted to fit on a mail line).
So it looks like custom might not like its old format anymore, causing
it to mishandle existing customizations (and even worse, completely
discard them when a new customization is saved).


In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2010-10-13 on leeloo
Windowing system distributor `The Cygwin/X Project', version 11.0.10503000
configured using `configure  '--with-x''

bug#7205: 24.0.50; Font customizations not being applied properly at startup

[Tim Van Holder]

On 13 October 2010 11:32, Tim Van Holder <tim.vanholder@gmail.com> wrote:
> This can't be reproduced with 'emacs -Q'.

Actually, it turns out customized faces keep on being lost - it's not
just my old ones.
This means I have a recipe with "emacs -Q" as well:

1) emacs -Q
2) eval (setq custom-file "~/bug7205.el")
3) customize font-lock-comment-face, changing the color to "HotPink",
save for future sessions
3) customize font-lock-function-name-face, changing the color to
"Goldenrod", save for future sessions
4) Exit emacs

At this point bug7205.el contains:

(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(font-lock-comment-face ((t (:foreground "HotPink"))))
 '(font-lock-function-name-face ((t (:foreground "Goldenrod")))))

5) emacs -Q
6) eval (setq custom-file "~/bug7205.el")
7) eval (load-file custom-file)
8) customize font-lock-comment-face: color is HotPink, but state is STANDARD
9) customize font-lock-function-name-face: color is Goldenrod, but
state is STANDARD
10) save for future sessions on font-lock-function-name-face
11) Exit emacs

At this point, bug7205.el contains just the stubs - at the point of
the save, Custom did not see any faces as customized, so it did not
emit anything:

(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )

bug#7205: 24.0.50; Font customizations not being applied properly at startup

[Tim Van Holder]

Looks like this was fixed by

  101960: Chong Yidong 2010-10-14 Fix 2010-10-12 change to
custom-theme-set-faces.

Faces are no longer lost when saving customizations, and they show up
as "SAVED and set" again.