From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: hide-show messages Date: Thu, 21 Oct 2010 23:18:04 +0200 Message-ID: <874ocf9reb.fsf@ambire.localdomain> References: <4CBFEABB.4000605@online.de> <87bp6nacc1.fsf@ambire.localdomain> <4CC07AC5.10605@online.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1287696157 14860 80.91.229.12 (21 Oct 2010 21:22:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 21 Oct 2010 21:22:37 +0000 (UTC) Cc: Emacs developers To: Andreas =?utf-8?Q?R=C3=B6hler?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 21 23:22:36 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P92ak-0002D3-Dq for ged-emacs-devel@m.gmane.org; Thu, 21 Oct 2010 23:22:30 +0200 Original-Received: from localhost ([127.0.0.1]:39315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P92aj-0001N2-Mx for ged-emacs-devel@m.gmane.org; Thu, 21 Oct 2010 17:22:29 -0400 Original-Received: from [140.186.70.92] (port=57501 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P92ad-0001Mx-83 for emacs-devel@gnu.org; Thu, 21 Oct 2010 17:22:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P92ab-0005Yq-LV for emacs-devel@gnu.org; Thu, 21 Oct 2010 17:22:23 -0400 Original-Received: from smtp206.alice.it ([82.57.200.102]:40959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P92ab-0005Yj-Cp for emacs-devel@gnu.org; Thu, 21 Oct 2010 17:22:21 -0400 Original-Received: from ambire.localdomain (95.245.66.62) by smtp206.alice.it (8.5.124.08) id 4C1A268C08259193; Thu, 21 Oct 2010 23:22:16 +0200 Original-Received: from ttn by ambire.localdomain with local (Exim 4.69) (envelope-from ) id 1P92WS-0003UU-EX; Thu, 21 Oct 2010 23:18:04 +0200 In-Reply-To: <4CC07AC5.10605@online.de> ("Andreas =?utf-8?Q?R=C3=B6hler=22?= =?utf-8?Q?'s?= message of "Thu, 21 Oct 2010 19:39:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Windows 98 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131958 Archived-At: () Andreas R=C3=B6hler () Thu, 21 Oct 2010 19:39:17 +0200 > Patch against latest source attached. > > Unfortunately, the patch does not document the changed interface. got it from git://repo.or.cz/emacs.git Sorry, i was not clear. Here is a verbose explanation of that sentence's intended meaning: A function's arglist is its interface. Before, =E2=80=98hs-show-all=E2=80=99 took no args; your patch introduces a= n (optional) arg; thus, there was a change in the interface. Two accompanying pieces of documentation are customary in cases like this: - that of the interface - that of the change in both interface and functionality A preferable patch would include some modifcation to the docstring describing the optional arg as well as a suitable ChangeLog entry, but as it turned out, these were missing. BTW your mail address there seems wrong. Yes, it has lapsed. Please feel free to ignore it. > Fortunately, this is an opportunity to revisit the need for those > messages. When hideshow.el was originally written, computers were > slower and such a message was reassuring when waiting for a big buffer > to be processed. Nowadays, i think it is better to completely remove > those messages as they have become more annoying than reassuring. This was my roundabout way of suggesting you post another (simpler) patch, removing those messages altogether. Ignoring cruft elegantly is ok, but pruning it (elegantly or not) is better.