From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#7289: Tramp changes ownership of remote file when saving Date: Thu, 28 Oct 2010 14:37:18 +0200 Message-ID: <874oc6ze69.fsf@gmx.de> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288269802 16795 80.91.229.12 (28 Oct 2010 12:43:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Oct 2010 12:43:22 +0000 (UTC) Cc: 7289@debbugs.gnu.org To: Jo Vermeulen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 28 14:43:20 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBRp7-0002Wq-TL for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Oct 2010 14:43:18 +0200 Original-Received: from localhost ([127.0.0.1]:45784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBRp7-0001fo-8a for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Oct 2010 08:43:17 -0400 Original-Received: from [140.186.70.92] (port=56625 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBRow-0001am-71 for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 08:43:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBRov-00037H-0c for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 08:43:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBRou-00037D-U1 for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 08:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PBRgB-0008V7-FB; Thu, 28 Oct 2010 08:34:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2010 12:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7289-submit@debbugs.gnu.org id=B7289.128826920132670 (code B ref 7289); Thu, 28 Oct 2010 12:34:03 +0000 Original-Received: (at 7289) by debbugs.gnu.org; 28 Oct 2010 12:33:21 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PBRfU-0008Ut-GA for submit@debbugs.gnu.org; Thu, 28 Oct 2010 08:33:20 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PBRfR-0008Un-Mx for 7289@debbugs.gnu.org; Thu, 28 Oct 2010 08:33:18 -0400 Original-Received: (qmail invoked by alias); 28 Oct 2010 12:37:24 -0000 Original-Received: from p4FC18D9F.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [79.193.141.159] by mail.gmx.net (mp016) with SMTP; 28 Oct 2010 14:37:24 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18M9Yl4MzsM1eaIuRtBVjFKdPyMWvlbeQp5wRa4Tg 1R8XXZIaZ1KoPn In-Reply-To: (Jo Vermeulen's message of "Wed, 27 Oct 2010 17:21:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 28 Oct 2010 08:34:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41194 Archived-At: Jo Vermeulen writes: > I don't think many people will run Emacs as root in this day and age. > However, they might log in as root on a remote server, or edit a file > as root (using sudo/su). Maybe Emacs or Tramp should also > automatically set the backup-by-copying-when-mismatch variable to t in > those cases? Could you, please, try the following patch? It is towards the Emacs-23 branch, line numbers might differ with your tramp.el. --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs-23/lisp/net/tramp.el.~100136~ 2010-10-28 14:31:49.730285001 +0200 --- /home/albinus/src/emacs-23/lisp/net/tramp.el 2010-10-28 14:29:40.990285001 +0200 *************** *** 5008,5014 **** (setq buffer-file-name filename) (setq buffer-read-only (not (file-writable-p filename))) (set-visited-file-modtime) ! (set-buffer-modified-p nil)) (when (and (stringp local-copy) (or remote-copy (null tramp-temp-buffer-file-name))) (delete-file local-copy)) --- 5008,5018 ---- (setq buffer-file-name filename) (setq buffer-read-only (not (file-writable-p filename))) (set-visited-file-modtime) ! (set-buffer-modified-p nil) ! ;; For root, preserve owner and group when editing files. ! (when (string-equal (file-remote-p filename 'user) "root") ! (set (make-local-variable 'backup-by-copying-when-mismatch) t) ! (put 'backup-by-copying-when-mismatch 'permanent-local t))) (when (and (stringp local-copy) (or remote-copy (null tramp-temp-buffer-file-name))) (delete-file local-copy)) --8<---------------cut here---------------end--------------->8--- > Thanks for your help! > > Cheers, > > -- Jo Best regards, Michael.