From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6301: 23.2.50; GC may lose Lisp objects in the image cache Date: Sun, 21 Nov 2010 19:45:22 -0500 Message-ID: <874oba5gpp.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290388483 32519 80.91.229.12 (22 Nov 2010 01:14:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 22 Nov 2010 01:14:43 +0000 (UTC) Cc: 6301@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 22 02:14:39 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PKKzO-0003Cs-9w for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Nov 2010 02:14:38 +0100 Original-Received: from localhost ([127.0.0.1]:60711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKKzN-0001u5-Iu for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Nov 2010 20:14:37 -0500 Original-Received: from [140.186.70.92] (port=44722 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKKzJ-0001tO-9s for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2010 20:14:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKKzI-0005Mm-5N for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2010 20:14:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKKzI-0005Mi-3x for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2010 20:14:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PKKSs-0007Fq-0M; Sun, 21 Nov 2010 19:41:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Nov 2010 00:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6301-submit@debbugs.gnu.org id=B6301.129038641127866 (code B ref 6301); Mon, 22 Nov 2010 00:41:01 +0000 Original-Received: (at 6301) by debbugs.gnu.org; 22 Nov 2010 00:40:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PKKS2-0007FP-SX for submit@debbugs.gnu.org; Sun, 21 Nov 2010 19:40:11 -0500 Original-Received: from pantheon-po42.its.yale.edu ([130.132.50.101]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PKKS1-0007FK-I0 for 6301@debbugs.gnu.org; Sun, 21 Nov 2010 19:40:09 -0500 Original-Received: from furball (dhcp128036014014.central.yale.edu [128.36.14.14]) (authenticated bits=0) by pantheon-po42.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id oAM0jMLW018365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 21 Nov 2010 19:45:22 -0500 Original-Received: by furball (Postfix, from userid 1000) id 7A4F31610A5; Sun, 21 Nov 2010 19:45:22 -0500 (EST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 21 Nov 2010 19:41:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41810 Archived-At: > Currently, Fgarbage_collect calls mark_terminals after marking > staticpro'ed objects. Terminal objects need a special marking > strategy with respect to image cache, but if a terminal object is > reachable from some staticpro'ed object, then it is marked normally > (i.e., without considering image cache). As a result, Lisp objects in > the image cache might be collected though they should have been > marked. > > Also, as for stack marking, I noticed that about half of the stack > elements have Lisp_Int* tags at least on Mac OS X. Such an element > might be either a real Lisp integer or an aligned pointer value. We > can omit mem_find calls for them by checking the tag value early. Thanks. I've committed your patches (the former to emacs-23, the latter to the trunk). Sorry for the long delay.