* bug#7717: 24.0.50; "games" user is hardcoded in build system
@ 2010-12-23 8:36 Ulrich Mueller
2010-12-29 11:14 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Mueller @ 2010-12-23 8:36 UTC (permalink / raw
To: 7717
[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 492 bytes --]
Tags: patch
The build system of Emacs currently hardcodes the "games" user that is
used for shared score files in ${localstatedir}. While usage of that
account name may be widespread, it is not universal. For example, in
Gentoo the name is configurable.
Since a variable "gameuser" and the autoconf plumbing for it already
exist, the only missing piece is a configure option. See attached
patch.
2010-12-22 Ulrich Mueller <ulm@gentoo.org>
* configure.in: Make gameuser configurable.
[-- Attachment #2: emacs-gameuser.diff --]
[-- Type: text/plain, Size: 963 bytes --]
--- emacs-orig/configure.in
+++ emacs/configure.in
@@ -45,8 +45,6 @@
docdir='${datadir}/emacs/${version}/etc'
gamedir='${localstatedir}/games/emacs'
-gameuser=games
-
dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING)
dnl Create a new --with option that defaults to being disabled.
dnl NAME is the base name of the option. The shell variable with_NAME
@@ -203,6 +201,13 @@
The default is /usr/lib, or /usr/lib64 on some platforms.])])
CRT_DIR="${with_crt_dir}"
+AC_ARG_WITH(gameuser,
+[AS_HELP_STRING([--with-gameuser=USER],
+ [user for shared score files; default games])])
+test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \
+ && gameuser="${with_gameuser}"
+test "X$gameuser" = X && gameuser=games
+
AC_ARG_WITH([gnustep-conf],dnl
[AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#7717: 24.0.50; "games" user is hardcoded in build system
2010-12-23 8:36 bug#7717: 24.0.50; "games" user is hardcoded in build system Ulrich Mueller
@ 2010-12-29 11:14 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-12-29 11:14 UTC (permalink / raw
To: Ulrich Mueller; +Cc: 7717-done
Ulrich Mueller <ulm@gentoo.org> writes:
> The build system of Emacs currently hardcodes the "games" user that is
> used for shared score files in ${localstatedir}. While usage of that
> account name may be widespread, it is not universal. For example, in
> Gentoo the name is configurable.
>
> Since a variable "gameuser" and the autoconf plumbing for it already
> exist, the only missing piece is a configure option. See attached
> patch.
Looks reasonable. Committed to trunk; thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-29 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23 8:36 bug#7717: 24.0.50; "games" user is hardcoded in build system Ulrich Mueller
2010-12-29 11:14 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.