From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Schulte Newsgroups: gmane.emacs.devel Subject: Re: How to fix Emacs24 compiler warning w/o breaking code for previous versions Date: Thu, 16 Jun 2011 21:45:35 -0700 Message-ID: <874o3pxdyb.fsf@gmail.com> References: <87oc1xd62s.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1308286005 10603 80.91.229.12 (17 Jun 2011 04:46:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2011 04:46:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 17 06:46:41 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QXQx6-0005i0-9c for ged-emacs-devel@m.gmane.org; Fri, 17 Jun 2011 06:46:40 +0200 Original-Received: from localhost ([::1]:47020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXQx5-0003XE-HC for ged-emacs-devel@m.gmane.org; Fri, 17 Jun 2011 00:46:39 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:32908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXQws-0003X9-OG for emacs-devel@gnu.org; Fri, 17 Jun 2011 00:46:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXQwr-0000UM-Ot for emacs-devel@gnu.org; Fri, 17 Jun 2011 00:46:26 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:64694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXQwr-0000UI-J1 for emacs-devel@gnu.org; Fri, 17 Jun 2011 00:46:25 -0400 Original-Received: by iwg8 with SMTP id 8so2230500iwg.0 for ; Thu, 16 Jun 2011 21:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:references:message-id :user-agent:mime-version:content-type; bh=+rzP4uEUhxCi9MfNMdXNnDbBZDtknNQ6pJulqy5LQjE=; b=OnD/rywfYqXzv5kgXiF6CrCE4XnWoFRFC94qLQaGwoXh7PKrX0dOfZtXQ4gcogkbkk 9enG/JjhVkUVYe1gfbcBGamcbSOxG89opoZr/OurkUgxIFn6NJPGsBibIvuld/YKAzCd OQ/CyeR/QZnSjM70KF2C69m6naYFa8uNsqAdI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:references:message-id:user-agent :mime-version:content-type; b=ACK3il0HO+BkxLDjYzDvYFfwFpcfgE2JllW5r96O+ylX5RCS6gNMcaj61cpH17gcO4 E8PxFxcHqL/U4dKAw3rU6QucbGtW4mhCem1xDUafxWeJaL3MHr7XlICC5bQ4+9ftR9wy nIzLT7XAvgrugTpZcoDZEVzozzuR3uifH5F3c= Original-Received: by 10.42.213.137 with SMTP id gw9mr1707556icb.158.1308285984460; Thu, 16 Jun 2011 21:46:24 -0700 (PDT) Original-Received: from bagel (c-71-202-151-156.hsd1.ca.comcast.net [71.202.151.156]) by mx.google.com with ESMTPS id gb8sm1204462ibb.43.2011.06.16.21.46.22 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Jun 2011 21:46:23 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140585 Archived-At: > > - Another good one is to support many versions, only pay attention to > warnings in the most recent supported version, and accept some warnings > as "better have the warnings than break backward compatibility". > This solution looks great to me. Thanks for the confirmation that the opinions of the byte-compiler don't trump clean code. Cheers -- Eric -- Eric Schulte http://cs.unm.edu/~eschulte/