[PATCH] icalendar: Make alarm duration RFC5545 compliant

[PATCH] icalendar: Make alarm duration RFC5545 compliant

[Michal Sojka]

The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.
---
 lisp/org-icalendar.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index c4b1f89..3632b5e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
 	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
 	    (if (and (> org-icalendar-alarm-time 0)
 		     (car t1) (nth 1 t1) (nth 2 t1))
-		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
 	      (setq alarm ""))
 	    )
 	  (if (string-match org-bracket-link-regexp summary)
-- 
1.7.2.3

[Accepted] icalendar: Make alarm duration RFC5545 compliant

[Carsten Dominik]

Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 12 May 2011 13:30:19 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 803
> Message-Id: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: Eric S Fraga <e.fraga@ucl.ac.uk>,
> 	emacs-orgmode@gnu.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
> 
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
> 
> ---
> lisp/org-icalendar.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index c4b1f89..3632b5e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
>  	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
>  	    (if (and (> org-icalendar-alarm-time 0)
>  		     (car t1) (nth 1 t1) (nth 2 t1))
> -		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> +		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
>  	      (setq alarm ""))
>  	    )
>  	  (if (string-match org-bracket-link-regexp summary)
> 

Re: [Accepted] icalendar: Make alarm duration RFC5545 compliant

[Michal Sojka]

Hi,

it seems that the following patch still didn't appear in the official
repo. Shall I resend it with the commit message according to
http://orgmode.org/worg/org-contribute.html#sec-5, especially with
TINYCHANGE?

Thanks,
Michal


On Fri, 13 May 2011, Carsten Dominik wrote:
> Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted".
> 
> Maintainer comment: none
> 
> This relates to the following submission:
> 
> http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E
> 
> Here is the original message containing the patch:
> 
> > Content-Type: text/plain; charset="utf-8"
> > MIME-Version: 1.0
> > Content-Transfer-Encoding: 7bit
> > Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> > Date: Thu, 12 May 2011 13:30:19 -0000
> > From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> > X-Patchwork-Id: 803
> > Message-Id: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de>
> > To: Eric S Fraga <e.fraga@ucl.ac.uk>,
> > 	emacs-orgmode@gnu.org
> > Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>
> > 
> > The format of alarm trigger was incorrect because "T" letter from
> > dur-time element was missing (see
> > http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> > software (such as KOrganizer) to not interpret the alarms correctly.
> > 
> > ---
> > lisp/org-icalendar.el |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> > index c4b1f89..3632b5e 100644
> > --- a/lisp/org-icalendar.el
> > +++ b/lisp/org-icalendar.el
> > @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
> >  	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
> >  	    (if (and (> org-icalendar-alarm-time 0)
> >  		     (car t1) (nth 1 t1) (nth 2 t1))
> > -		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> > +		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> >  	      (setq alarm ""))
> >  	    )
> >  	  (if (string-match org-bracket-link-regexp summary)
> > 

Re: [Accepted] icalendar: Make alarm duration RFC5545 compliant

[Bastien]

Hi Michal,

Michal Sojka <sojka@os.inf.tu-dresden.de> writes:

> Shall I resend it with the commit message according to
> http://orgmode.org/worg/org-contribute.html#sec-5, especially with
> TINYCHANGE?

Yes, please do.  Take care of the following:

- use git format-patch if possible
- create a ChangeLog entry with `C-x 4 a'
- start sentences with an upper-case letter
- add "." at the end of the sentences
- use two whitespaces at the end of sentences
- put variable and function names within `...'
- add TINYCHANGE 

Thanks!

-- 
 Bastien, un-procrastinating nitpicking :)

[PATCH] icalendar: Make alarm duration RFC5545 compliant

[Michal Sojka]

* org-icalendar.el (org-print-icalendar-entries): Make alarm duration
RFC5545 compliant.

The format of alarm trigger was incorrect because "T" letter from
dur-time element was missing (see
http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
software (such as KOrganizer) to not interpret the alarms correctly.

TINYCHANGE
---
 lisp/org-icalendar.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
index bc0efce..a3ea88e 100644
--- a/lisp/org-icalendar.el
+++ b/lisp/org-icalendar.el
@@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
 	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
 	    (if (and (> org-icalendar-alarm-time 0)
 		     (car t1) (nth 1 t1) (nth 2 t1))
-		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
+		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
 	      (setq alarm ""))
 	    )
 	  (if (string-match org-bracket-link-regexp summary)
-- 
1.7.5.4

[Accepted] icalendar: Make alarm duration RFC5545 compliant

[Bastien Guerry]

Patch 913 (http://patchwork.newartisans.com/patch/913/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1314282867-11165-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 25 Aug 2011 19:34:27 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 913
> Message-Id: <1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: bzg@altern.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>, cdominik@newartisans.com,
> 	emacs-orgmode@gnu.org
> 
> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.
> 
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
> 
> TINYCHANGE
> 
> ---
> lisp/org-icalendar.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index bc0efce..a3ea88e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
>  	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
>  	    (if (and (> org-icalendar-alarm-time 0)
>  		     (car t1) (nth 1 t1) (nth 2 t1))
> -		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> +		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
>  	      (setq alarm ""))
>  	    )
>  	  (if (string-match org-bracket-link-regexp summary)
> 

Re: [PATCH] icalendar: Make alarm duration RFC5545 compliant

[Bastien]

Michal Sojka <sojka@os.inf.tu-dresden.de> writes:

> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.

Applied -- thanks a lot for making the effort of providing the
ChangeLog!

Best,

-- 
 Bastien