From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.bugs Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Date: Sun, 25 Sep 2011 14:19:07 +0200 Message-ID: <874o00erwk.fsf@keller.adm.naquadah.org> References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> <87wrcydnuq.fsf@keller.adm.naquadah.org> <877h4yc8gm.fsf@gmx.de> <87aa9setsi.fsf@keller.adm.naquadah.org> <87mxdsvnm6.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1316953175 26588 80.91.229.12 (25 Sep 2011 12:19:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Sep 2011 12:19:35 +0000 (UTC) Cc: 9581@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 25 14:19:31 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R7ngA-0003zj-Fe for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Sep 2011 14:19:30 +0200 Original-Received: from localhost ([::1]:56674 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7ng9-000430-WC for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Sep 2011 08:19:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7ng6-00042s-Qx for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2011 08:19:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7ng5-0002D0-Qg for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2011 08:19:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7ng5-0002Cw-Mg for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2011 08:19:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R7ngg-0007d9-FN for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2011 08:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2011 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.131695319129312 (code B ref 9581); Sun, 25 Sep 2011 12:20:02 +0000 Original-Received: (at 9581) by debbugs.gnu.org; 25 Sep 2011 12:19:51 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7ngV-0007ci-5J for submit@debbugs.gnu.org; Sun, 25 Sep 2011 08:19:51 -0400 Original-Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7ngR-0007cX-NR for 9581@debbugs.gnu.org; Sun, 25 Sep 2011 08:19:49 -0400 Original-Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id BAE0B5C0F4; Sun, 25 Sep 2011 14:19:08 +0200 (CEST) In-Reply-To: <87mxdsvnm6.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Sep 2011 13:59:45 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 25 Sep 2011 08:20:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51814 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Sep 25 2011, Michael Albinus wrote: > `dbus-register-signal' checks for the a valid service name, if it isn't > nil. Usually, "some.service" is not known; in my test > `dbus-register-signal' raises an error then. > > How did you manage to register your signal with that service? No idea. But the check seems to be not functionnal here obviously. >> ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded") >> ("" >> "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity >> "=C2=82"))) > > This entry has a corrupted match rule. Again, which trick brings > `dbus-register-signal' to accept it? I must implement a counter-check > for this! Yes. If you want me to test a patch before committing it, or to run a debug patch with some printf or whatever, do not hesitate. >> Then I call unregister it yells: >> Debugger entered--Lisp error: (dbus-error "Unable to append argument" "\= 202") >> dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBu= s" "org.freedesktop.DBus" "RemoveMatch" "\202") >> >> Where the last string is obviously the same as I talked about above. :) > > Which is the correct answer, because there isn't a valid match rule. I > could add a check for a valid match rule before sending the > "RemoveMatch" message, but I believe this is superfluous, because there > is exactly one place that match rule is appended. At this place, we must > prevent wrong values. Again, be careful on one last thing. I did a couple of tests in an Emacs session, and sometimes I saw: method call sender=3D:1.254 -> dest=3Dorg.freedesktop.DBus serial=3D27 path= =3D/org/freedesktop/DBus; interface=3Dorg.freedesktop.DBus; member=3DReleas= eName string "some.service" And I was *only* testing dbus-register-signal, so there seems to be still some case or the "(when service =E2=80=A6" stuff is doing ReleaseName= even on a signal match. =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfxw7AAoJEGEbqVCLeKXCfkIP/jNqlAOnOacZcqWVqNaVCkdq EjQXuY8aYE59+HC6TGSknRZvPHEtGVonDqPW1RX2piyPPMWiGowd/nfLJJiAzIFL 7snz8aezD1SsJuzWlv9Hqe852vcEDHC0bllapYSxY8wF8GDBSezizg6kbwoMXqYn djjtyykT+pJn/kxCK9Pcb2NmRr4Zy3tolQAh69VR3UMyXavuje2ozeBZ2Xrrb1bA 9p8uXejaZ7kiW0lzwDdzCGI7XL7YrMnFPccgOgKiuBaCiXHKH2pZJh3GrANmdTqR nfWgZNfkK6b7UXpSWxitxnzCkV9/VhfsF15FDMrwTeKi/ZhmUMWkVll0lSCBE3pe AJIbsiRI1+pKd4nwqLzjtzCieiBnW7M5blQWW0gKy/gW1OtBiTbK7ZuAiZSG5Svz uqyMGoaM6wEUKa7VcGskG522Cgl69CYk2rDrUSR3d23qSLNqYYpGIIXVqyX6RRo5 wvbW6O+L0D/2mifAi1x5ZPF27aN0ACwmhus+Lt+6gNL9NWrXpsQfmZUepkChSTo6 6ZwZ75jrAPeUtSWQJj3PtyWKRc0ZXry7Vuh6fu5BxFLBYzh2uEElJZjsLNY7r08x vWzeMHIAbWYlkjrReezrweao6yBNj94DtKkAMqYYUXxWnA4KE5xyWWow1LuryHvQ ioF1+6831hP1lXn6ToxP =WUjn -----END PGP SIGNATURE----- --=-=-=--