From: Julien Danjou <julien@danjou.info>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 9581@debbugs.gnu.org
Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil
Date: Sun, 25 Sep 2011 14:19:07 +0200 [thread overview]
Message-ID: <874o00erwk.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: <87mxdsvnm6.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Sep 2011 13:59:45 +0200")
[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]
On Sun, Sep 25 2011, Michael Albinus wrote:
> `dbus-register-signal' checks for the a valid service name, if it isn't
> nil. Usually, "some.service" is not known; in my test
> `dbus-register-signal' raises an error then.
>
> How did you manage to register your signal with that service?
No idea. But the check seems to be not functionnal here obviously.
>> ((:session "org.gtk.Private.RemoteVolumeMonitor" "VolumeAdded")
>> (""
>> "some.service" "/org/gtk/Private/RemoteVolumeMonitor" identity
>> "")))
>
> This entry has a corrupted match rule. Again, which trick brings
> `dbus-register-signal' to accept it? I must implement a counter-check
> for this!
Yes. If you want me to test a patch before committing it, or to run a
debug patch with some printf or whatever, do not hesitate.
>> Then I call unregister it yells:
>> Debugger entered--Lisp error: (dbus-error "Unable to append argument" "\202")
>> dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" "org.freedesktop.DBus" "RemoveMatch" "\202")
>>
>> Where the last string is obviously the same as I talked about above. :)
>
> Which is the correct answer, because there isn't a valid match rule. I
> could add a check for a valid match rule before sending the
> "RemoveMatch" message, but I believe this is superfluous, because there
> is exactly one place that match rule is appended. At this place, we must
> prevent wrong values.
Again, be careful on one last thing. I did a couple of tests in an Emacs
session, and sometimes I saw:
method call sender=:1.254 -> dest=org.freedesktop.DBus serial=27 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=ReleaseName
string "some.service"
And I was *only* testing dbus-register-signal, so there seems to be
still some case or the "(when service …" stuff is doing ReleaseName even
on a signal match.
--
Julien Danjou
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-09-25 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 23:01 bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Julien Danjou
2011-09-23 15:37 ` Michael Albinus
2011-09-23 16:12 ` Julien Danjou
2011-09-24 11:50 ` Michael Albinus
2011-09-24 14:19 ` Julien Danjou
2011-09-24 14:37 ` Michael Albinus
2011-09-25 11:38 ` Julien Danjou
2011-09-25 11:59 ` Michael Albinus
2011-09-25 12:19 ` Julien Danjou [this message]
2011-09-25 16:03 ` Michael Albinus
2011-09-26 12:16 ` Julien Danjou
2011-09-26 13:57 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o00erwk.fsf@keller.adm.naquadah.org \
--to=julien@danjou.info \
--cc=9581@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.