From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: changes to cfengine-mode Date: Wed, 21 Dec 2011 06:31:23 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <874nwu9n5g.fsf@lifelogs.com> References: <87ipmcgjot.fsf@lifelogs.com> <83lir89gne.fsf@gnu.org> <87aa7ogfo3.fsf@lifelogs.com> <87fwhffv37.fsf@lifelogs.com> <877h2ridev.fsf@gnu.org> <8739dfezc1.fsf@lifelogs.com> <87aa7m5a6b.fsf@gnu.org> <877h2oe3yj.fsf@lifelogs.com> <877h2ngnhb.fsf@marauder.physik.uni-ulm.de> <87hb1qb9ot.fsf@lifelogs.com> <87pqg82tdy.fsf@lifelogs.com> <87pqg7x89t.fsf_-_@lifelogs.com> <8739cwtzh8.fsf@lifelogs.com> <87iplk9ylb.fsf@lifelogs.com> <87pqfs16x0.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1324467118 26466 80.91.229.12 (21 Dec 2011 11:31:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2011 11:31:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 21 12:31:54 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RdKOo-0001Gt-9m for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2011 12:31:54 +0100 Original-Received: from localhost ([::1]:51619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdKOn-0000nq-RC for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2011 06:31:53 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdKOk-0000nF-OS for emacs-devel@gnu.org; Wed, 21 Dec 2011 06:31:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RdKOZ-0005hz-RF for emacs-devel@gnu.org; Wed, 21 Dec 2011 06:31:50 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:44460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdKOZ-0005he-ED for emacs-devel@gnu.org; Wed, 21 Dec 2011 06:31:39 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RdKOX-00019o-Ev for emacs-devel@gnu.org; Wed, 21 Dec 2011 12:31:37 +0100 Original-Received: from c-76-28-40-19.hsd1.vt.comcast.net ([76.28.40.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Dec 2011 12:31:37 +0100 Original-Received: from tzz by c-76-28-40-19.hsd1.vt.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Dec 2011 12:31:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 27 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-76-28-40-19.hsd1.vt.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) Cancel-Lock: sha1:akXhOenbcnGiYW6AcD7fEItg2CU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146896 Archived-At: On Fri, 16 Dec 2011 19:45:53 -0500 Stefan Monnier wrote: >> OK. See attached, and I hope final, patch. SM> A few more nit picks, feel free to install the patch after addressing them. Done. I left the Version header in; feel free to remove it if plans change. SM> Why not merge the two entries into something like: SM> (,(concat "\\<" cfengine3-defuns-regex "\\>" SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\>" SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\(?:(\\([^)]*\\))\\)?") SM> (1 font-lock-builtin-face) SM> (2 font-lock-constant-face) SM> (3 font-lock-function-name-face) SM> (4 font-lock-variable-name-face nil t)) I thought my version was easier to read, but I used yours with an extra comment to explain the last part. SM> And please make sure you explain in the commit log (or here in SM> comments) why this code was moved to the beginning of SM> cfengine3-font-lock-keywords. OK, done in the comments. Ted