From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: changes to cfengine-mode
Date: Wed, 21 Dec 2011 06:31:23 -0500 [thread overview]
Message-ID: <874nwu9n5g.fsf@lifelogs.com> (raw)
In-Reply-To: jwvzkes9gq8.fsf-monnier+emacs@gnu.org
On Fri, 16 Dec 2011 19:45:53 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> OK. See attached, and I hope final, patch.
SM> A few more nit picks, feel free to install the patch after addressing them.
Done. I left the Version header in; feel free to remove it if plans change.
SM> Why not merge the two entries into something like:
SM> (,(concat "\\<" cfengine3-defuns-regex "\\>"
SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\>"
SM> "[ \t]+\\<\\([[:alnum:]_]+\\)\\(?:(\\([^)]*\\))\\)?")
SM> (1 font-lock-builtin-face)
SM> (2 font-lock-constant-face)
SM> (3 font-lock-function-name-face)
SM> (4 font-lock-variable-name-face nil t))
I thought my version was easier to read, but I used yours with an extra
comment to explain the last part.
SM> And please make sure you explain in the commit log (or here in
SM> comments) why this code was moved to the beginning of
SM> cfengine3-font-lock-keywords.
OK, done in the comments.
Ted
next prev parent reply other threads:[~2011-12-21 11:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 17:18 prog-mode not available in earlier Emacsen, need help with cfengine.el Ted Zlatanov
2011-11-22 18:05 ` Eli Zaretskii
2011-11-22 18:45 ` Ted Zlatanov
2011-11-22 22:30 ` Stefan Monnier
2011-11-23 2:09 ` Ted Zlatanov
2011-11-23 6:03 ` Chong Yidong
2011-11-23 13:35 ` Ted Zlatanov
2011-11-24 6:03 ` Chong Yidong
2011-11-25 13:17 ` Ted Zlatanov
2011-11-26 10:57 ` Reiner Steib
2011-11-27 2:06 ` Ted Zlatanov
2011-12-01 15:39 ` Ted Zlatanov
2011-12-02 16:12 ` changes to cfengine-mode (was: prog-mode not available in earlier Emacsen, need help with cfengine.el) Ted Zlatanov
2011-12-02 20:32 ` changes to cfengine-mode Stefan Monnier
2011-12-07 11:04 ` Ted Zlatanov
2011-12-07 16:10 ` Stefan Monnier
2011-12-08 9:52 ` Chong Yidong
2011-12-13 17:21 ` Ted Zlatanov
2011-12-13 19:51 ` Stefan Monnier
2011-12-13 21:46 ` Ted Zlatanov
2011-12-17 0:45 ` Stefan Monnier
2011-12-21 11:31 ` Ted Zlatanov [this message]
2011-12-13 17:23 ` Ted Zlatanov
2011-12-07 16:12 ` Stefan Monnier
2011-12-13 15:47 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nwu9n5g.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.