From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Tue, 28 Feb 2012 07:12:49 +0100 Message-ID: <874nubzdsu.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <83pqd4roav.fsf@gnu.org> <87haygx97t.fsf@gmx.de> <87aa47rj6z.fsf@gmail.com> <878vjrxpej.fsf@gmx.de> <87pqd3i8ky.fsf@gmail.com> <87ipiuvsbw.fsf@gmx.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> <87bookhfcn.fsf@gmail.com> <87aa44o7qo.fsf@gmail.com> <87ty2c490n.fsf@gmail.com> <87r4xgkt2b.fsf@gmail.com> <87obskum9i.fsf@gmx.de> <874nuc9bao.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330409674 32266 80.91.229.3 (28 Feb 2012 06:14:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2012 06:14:34 +0000 (UTC) To: 10489@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 28 07:14:30 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2GKT-0006Qr-PD for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 07:14:29 +0100 Original-Received: from localhost ([::1]:39999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GKS-0005tp-Uj for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 01:14:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GKO-0005ti-VX for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:14:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2GKM-0004ab-Ki for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:14:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GKM-0004aU-GK for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:14:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S2GMw-0005i6-65 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:17:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87mx9su32g.fsf@web.de> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Feb 2012 06:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133040980721926 (code B ref -1); Tue, 28 Feb 2012 06:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2012 06:16:47 +0000 Original-Received: from localhost ([127.0.0.1]:60626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2GMf-0005hQ-DK for submit@debbugs.gnu.org; Tue, 28 Feb 2012 01:16:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37371) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2GMI-0005gr-JP for submit@debbugs.gnu.org; Tue, 28 Feb 2012 01:16:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2GJC-0004D0-M1 for submit@debbugs.gnu.org; Tue, 28 Feb 2012 01:13:11 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:35477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GJC-0004Cs-Iu for submit@debbugs.gnu.org; Tue, 28 Feb 2012 01:13:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GJA-0005pM-PM for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:13:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2GJ8-0004CD-Aj for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:13:08 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:56355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2GJ8-0004Bw-4e for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 01:13:06 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S2GJ3-0005i0-Fj for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 07:13:01 +0100 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Feb 2012 07:13:01 +0100 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Feb 2012 07:13:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) Cancel-Lock: sha1:rtTAUHRflAQR+sKeKZnvsFQLot8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57341 Archived-At: Thierry Volpiatto writes: > Stefan Monnier writes: > >>>> If you don't create "test1" and file-subdir-of-p is unable to handle a >>>> non--existing directory,I don't understand how you want to do. >>> I was saying that files-equal-p returns unexpected results in case both >>> files do not exist. I haven't spoken about file-subdir-of-p. >> >> Exactly. I don't think noexist is needed for subdir-p (it should accept >> a non-existing dir for the `dir1' argument, without any need for >> a noexist arg and it should reject a non-existing dir2), but I can live >> with it, but file-equal-p only makes sense for existing files and should >> not have a `noexist' argument. > Ah! yes, thats sound good. > Just need to remove check of file-directory-p for dir1 in f-subdir-of-p. Note that the last check: (files-equal-p (file-truename root) dir2) can be: (files-equal-p root dir2) file-truename is not needed here. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997